thermal: make lockdep happy
in [Kernel]
|
Prev: x86: Do not write to VGA memory space if CONFIG_VGA_CONSOLE is undefined
Next: PCI quirk: RS780/RS880: work around missing MSI initialization
From: Christian Casteyde on 31 Mar 2010 16:20 Seems to fix it, at least when applied on -rc3. I'm updating the bugzilla entry. Thanks. Le mercredi 31 mars 2010, Dan Carpenter a �crit�: > Hi Christian, > > Can you test this patch? > > I wrote this to address bugzilla bug: > https://bugzilla.kernel.org/show_bug.cgi?id=15504 > BUG: key ffff88004c3811e0 not in .data! occured in lockdep.c > > We now have to call sysfs_attr_init() for dynamically allocated sysfs > attributes or lockdep complains. > > Signed-off-by: Dan Carpenter <error27(a)gmail.com> > > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c > index 5066de5..d4fec47 100644 > --- a/drivers/thermal/thermal_sys.c > +++ b/drivers/thermal/thermal_sys.c > @@ -725,6 +725,7 @@ int thermal_zone_bind_cooling_device(struct > thermal_zone_device *tz, goto release_idr; > > sprintf(dev->attr_name, "cdev%d_trip_point", dev->id); > + sysfs_attr_init(&dev->attr.attr); > dev->attr.attr.name = dev->attr_name; > dev->attr.attr.mode = 0444; > dev->attr.show = thermal_cooling_device_trip_point_show; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Zhang Rui on 31 Mar 2010 21:50
On Thu, 2010-04-01 at 01:09 +0800, Dan Carpenter wrote: > Hi Christian, > > Can you test this patch? > > I wrote this to address bugzilla bug: > https://bugzilla.kernel.org/show_bug.cgi?id=15504 > BUG: key ffff88004c3811e0 not in .data! occured in lockdep.c > > We now have to call sysfs_attr_init() for dynamically allocated sysfs > attributes or lockdep complains. > > Signed-off-by: Dan Carpenter <error27(a)gmail.com> Acked-by: Zhang Rui <rui.zhang(a)intel.com> > > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c > index 5066de5..d4fec47 100644 > --- a/drivers/thermal/thermal_sys.c > +++ b/drivers/thermal/thermal_sys.c > @@ -725,6 +725,7 @@ int thermal_zone_bind_cooling_device(struct thermal_zone_device *tz, > goto release_idr; > > sprintf(dev->attr_name, "cdev%d_trip_point", dev->id); > + sysfs_attr_init(&dev->attr.attr); > dev->attr.attr.name = dev->attr_name; > dev->attr.attr.mode = 0444; > dev->attr.show = thermal_cooling_device_trip_point_show; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |