[tip:perf/core] x86, perf: P4 PMU -- Get rid of redundant check for array index
in [Kernel]
|
Prev: [tip:perf/core] x86, perf: P4 PMU -- check for proper event index in RAW events
Next: [tip:perf/core] x86, perf: P4 PMU -- protect sensible procedures from preemption
From: tip-bot for Cyrill Gorcunov on 8 May 2010 12:20 Commit-ID: 3f51b7119d052827dbb0e40c966acdf2bdc6f47f Gitweb: http://git.kernel.org/tip/3f51b7119d052827dbb0e40c966acdf2bdc6f47f Author: Cyrill Gorcunov <gorcunov(a)openvz.org> AuthorDate: Sat, 8 May 2010 15:25:53 +0400 Committer: Ingo Molnar <mingo(a)elte.hu> CommitDate: Sat, 8 May 2010 14:17:53 +0200 x86, perf: P4 PMU -- Get rid of redundant check for array index The caller already has done such a check. And it was wrong anyway, it had to be '>=' rather than '>' Signed-off-by: Cyrill Gorcunov <gorcunov(a)openvz.org> Cc: Peter Zijlstra <peterz(a)infradead.org> Cc: Frederic Weisbecker <fweisbec(a)gmail.com> Cc: Lin Ming <ming.m.lin(a)intel.com> LKML-Reference: <20100508112717.130386882(a)openvz.org> Signed-off-by: Ingo Molnar <mingo(a)elte.hu> --- arch/x86/kernel/cpu/perf_event_p4.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/arch/x86/kernel/cpu/perf_event_p4.c b/arch/x86/kernel/cpu/perf_event_p4.c index ca40180..b8c2d37 100644 --- a/arch/x86/kernel/cpu/perf_event_p4.c +++ b/arch/x86/kernel/cpu/perf_event_p4.c @@ -406,11 +406,6 @@ static u64 p4_pmu_event_map(int hw_event) unsigned int esel; u64 config; - if (hw_event > ARRAY_SIZE(p4_general_events)) { - printk_once(KERN_ERR "P4 PMU: Bad index: %i\n", hw_event); - return 0; - } - config = p4_general_events[hw_event]; bind = p4_config_get_bind(config); esel = P4_OPCODE_ESEL(bind->opcode); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |