Prev: [PATCH] Driver core: Add BUS_NOTIFY_BIND_DRIVER
Next: tmio_mmc: Allow 2 byte requests in 4-bit mode
From: tip-bot for Stefano Stabellini on 23 Jul 2010 07:00
Commit-ID: ff4878089e1eaeac79d57878ad4ea32910fb4037
Gitweb: http://git.kernel.org/tip/ff4878089e1eaeac79d57878ad4ea32910fb4037
Author: Stefano Stabellini <stefano.stabellini(a)eu.citrix.com>
AuthorDate: Wed, 21 Jul 2010 18:32:37 +0100
Committer: Thomas Gleixner <tglx(a)linutronix.de>
CommitDate: Fri, 23 Jul 2010 12:53:00 +0200

x86: Do not try to disable hpet if it hasn't been initialized before

hpet_disable is called unconditionally on machine reboot if hpet support
is compiled in the kernel.
hpet_disable only checks if the machine is hpet capable but doesn't make
sure that hpet has been initialized.

[ tglx: Made it a one liner and removed the redundant hpet_address check ]

Signed-off-by: Stefano Stabellini <stefano.stabellini(a)eu.citrix.com>
Acked-by: Venkatesh Pallipadi <venki(a)google.com>
LKML-Reference: <alpine.DEB.2.00.1007211726240.22235(a)kaball-desktop>
Cc: stable(a)kernel.org
Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de>
---
arch/x86/kernel/hpet.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
index a198b7c..ba390d7 100644
--- a/arch/x86/kernel/hpet.c
+++ b/arch/x86/kernel/hpet.c
@@ -964,7 +964,7 @@ fs_initcall(hpet_late_init);

void hpet_disable(void)
{
- if (is_hpet_capable()) {
+ if (is_hpet_capable() && hpet_virt_address) {
unsigned int cfg = hpet_readl(HPET_CFG);

if (hpet_legacy_int_enabled) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] Driver core: Add BUS_NOTIFY_BIND_DRIVER
Next: tmio_mmc: Allow 2 byte requests in 4-bit mode