Prev: [BUG-REPORT] [PREEMPT_RT] Build break with DRM_I915 and HAVE_ATOMIC_IOMAP
Next: tmpfs: fix oops on mounts with mpol=default
From: Lee Schermerhorn on 17 Mar 2010 10:20
On Tue, 2010-03-16 at 14:50 +0900, KOSAKI Motohiro wrote:
> Currently, following mount operation cause mount error.
>
> % mount -t tmpfs -ompol=bind:0 none /tmp
>
> Because commit 71fe804b6d5 (mempolicy: use struct mempolicy pointer in
> shmem_sb_info) corrupted MPOL_BIND parse code.
>
> This patch restore the needed one.
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro(a)jp.fujitsu.com>
> Cc: Ravikiran Thirumalai <kiran(a)scalex86.org>
> Cc: Christoph Lameter <cl(a)linux-foundation.org>
> Cc: Mel Gorman <mel(a)csn.ul.ie>
> Cc: Lee Schermerhorn <lee.schermerhorn(a)hp.com>
> Cc: Hugh Dickins <hugh.dickins(a)tiscali.co.uk>
> Cc: <stable(a)kernel.org>

There's a trailing space in the patch, but except for that:

Acked-by: Lee Schermerhorn <lee.schermerhorn(a)hp.com>

> ---
> mm/mempolicy.c | 10 +++++++---
> 1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 25a0c0f..3f77062 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -2220,9 +2220,13 @@ int mpol_parse_str(char *str, struct mempolicy **mpol, int no_context)
> if (!nodelist)
> err = 0;
> goto out;
> - /*
> - * case MPOL_BIND: mpol_new() enforces non-empty nodemask.
> - */
> + case MPOL_BIND:
> + /*
trailing space ^

> + * Insist on a nodelist
> + */
> + if (!nodelist)
> + goto out;
> + err = 0;
> }
>
> mode_flags = 0;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [BUG-REPORT] [PREEMPT_RT] Build break with DRM_I915 and HAVE_ATOMIC_IOMAP
Next: tmpfs: fix oops on mounts with mpol=default