tty: avoid recursive BTM in pty_close
in [Kernel]
|
Prev: [PATCH 0/3} hwmon: Driver for SMM665 Six-Channel Active DC Output Controller/Monitor
Next: USB: gadget: g_multi: added documentation and INF files
From: Tony Luck on 28 Jun 2010 13:20 On Fri, Jun 18, 2010 at 11:35 AM, Arnd Bergmann <arnd(a)arndb.de> wrote: >> Call Trace: >> �[<a0000001000159d0>] show_stack+0x50/0xa0 >> �[<a00000010090f270>] dump_stack+0x30/0x50 >> �[<a00000010008e2c0>] warn_slowpath_common+0xc0/0x120 >> �[<a00000010008e360>] warn_slowpath_null+0x40/0x60 >> �[<a00000010053eb40>] tty_open+0x160/0xc60 >> �[<a0000001001af9b0>] chrdev_open+0x310/0x360 >> �[<a0000001001a58b0>] __dentry_open+0x350/0x680 >> �[<a0000001001a5d80>] nameidata_to_filp+0x80/0xc0 >> �[<a0000001001bfee0>] finish_open+0x160/0x380 >> �[<a0000001001c0cc0>] do_last+0xbc0/0xce0 >> �[<a0000001001c5270>] do_filp_open+0x2f0/0xb40 >> �[<a0000001001a5290>] do_sys_open+0x90/0x200 >> �[<a0000001001a54d0>] sys_open+0x50/0x80 >> �[<a000000100b907e0>] kernel_init+0x340/0x420 >> �[<a000000100013c10>] kernel_thread_helper+0x30/0x60 >> �[<a00000010000a0c0>] start_kernel_thread+0x20/0x40 > > Ok, this is the same one you reported at first. I forgot to > mention that the other patch I sent as a reply to your report > is still needed and not yet in -next since I'm trying to > sort through the other BKL removal patches now. > This instance of the WARN_ON is completely harmless though, > you could consider this one a false positive. Quick status check. I'm still seeing these messages in next-20100628. Are you still working on a fix? -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Arnd Bergmann on 28 Jun 2010 15:10
On Monday 28 June 2010 19:17:39 Tony Luck wrote: > On Fri, Jun 18, 2010 at 11:35 AM, Arnd Bergmann <arnd(a)arndb.de> wrote: > >> Call Trace: > >> [<a0000001000159d0>] show_stack+0x50/0xa0 > >> [<a00000010090f270>] dump_stack+0x30/0x50 > >> [<a00000010008e2c0>] warn_slowpath_common+0xc0/0x120 > >> [<a00000010008e360>] warn_slowpath_null+0x40/0x60 > >> [<a00000010053eb40>] tty_open+0x160/0xc60 > >> [<a0000001001af9b0>] chrdev_open+0x310/0x360 > >> [<a0000001001a58b0>] __dentry_open+0x350/0x680 > >> [<a0000001001a5d80>] nameidata_to_filp+0x80/0xc0 > >> [<a0000001001bfee0>] finish_open+0x160/0x380 > >> [<a0000001001c0cc0>] do_last+0xbc0/0xce0 > >> [<a0000001001c5270>] do_filp_open+0x2f0/0xb40 > >> [<a0000001001a5290>] do_sys_open+0x90/0x200 > >> [<a0000001001a54d0>] sys_open+0x50/0x80 > >> [<a000000100b907e0>] kernel_init+0x340/0x420 > >> [<a000000100013c10>] kernel_thread_helper+0x30/0x60 > >> [<a00000010000a0c0>] start_kernel_thread+0x20/0x40 > > > > Ok, this is the same one you reported at first. I forgot to > > mention that the other patch I sent as a reply to your report > > is still needed and not yet in -next since I'm trying to > > sort through the other BKL removal patches now. > > This instance of the WARN_ON is completely harmless though, > > you could consider this one a false positive. > > Quick status check. I'm still seeing these messages in next-20100628. > Are you still working on a fix? I got distracted and it wasn't on my list of pressing issues because this particular warning is harmless. I should get the base bkl series into -next to fix this. For the other issue (garbled output), I'm not sure how to proceed. Alan didn't like the easy workaround of reverting the commit that introduced it and the fix that Alan suggested only solved the problem partially as far as I can tell. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |