tty: release_one_tty() forgets to put pids
in [Kernel]
|
Prev: [PATCH 04/14] Allow CONFIG_MIGRATION to be set without CONFIG_NUMA or memory hot-remove
Next: [GIT PULL] tracing: updates
From: Alan Cox on 2 Apr 2010 16:10 > So I'll ACK it. But maybe Alan sees some problem/issue I didn't see. I have no idea. Someone with the time (not me right now) will have to trace the error paths or perhaps play safe and NULL any pointers so that they can free it in the destructor only if one was set ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Tetsuo Handa on 2 Apr 2010 22:50 Oleg Nesterov wrote: > Add cc's. > > On 03/31, Andrew Morton wrote: > > > > On Tue, 30 Mar 2010 16:31:13 +0100 > > Catalin Marinas <catalin.marinas(a)arm.com> wrote: > > > > > Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> wrote: > > > > I got below report with 2.6.33.1 . > > > > > > > > unreferenced object 0xde144600 (size 64): > > > > comm "init", pid 1, jiffies 4294678101 (age 291.508s) > > > > > > [... snip ...] > > > > > > I reported similar leaks last year - > > > http://lkml.org/lkml/2009/7/8/422. There is some analysis in the thread > > > above of the reference counting but I couldn't figure out where it goes > > > wrong. It looks to me like there isn't any reference to a struct pid > > > block but its reference count is 2. > > > > > > There is a bugzilla entry as well - > > > https://bugzilla.kernel.org/show_bug.cgi?id=13868 > > OK. I do not undertand ttys, absolutely. This means the patch > should not be applied without acks. And in fact I feel the patch > probably fixes the symptom, not the problem. But the logic in > disassociate_ctty() is beyond my understanding. > > However, I think it is easy to explain the leak. > > Catalin, Tetsuo, could you try this patch? > I confirmed using 2.6.34-rc3 that this patch solved the leak. Thank you. > Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Linus Torvalds on 2 Apr 2010 23:20
Ok, I committed this, but after committing I realized that the patch didn't have the "Cc: stable(a)kernel.org", even if the email did. So Greg et al: it's now commit 6da8d866d0d39e9509ff826660f6a86a6757c966 in mainline. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |