uniform cdrom: fix mutex unlocking in /proc/sys/dev/cdrom/info file
in [Kernel]
|
Prev: TCP connections on 'lo' interface randomly stall
Next: Fwd: [2.6.34] INFO: task rsync:20019 blocked for more than 120 seconds.
From: Andrew Morton on 14 Jun 2010 15:40 On Wed, 09 Jun 2010 12:56:50 -0400 Davidlohr Bueso <dave.bueso(a)gmail.com> wrote: > If the last if condition passes the cdrom_mutex mutex will not be unlocked. > This patch fixes this and also removes the unnecessary doit label that was only invoked by the done label. > Confused. There is no way in which cdrom_sysctl_info() can forget to unlock cdrom_mutex. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Davidlohr Bueso on 15 Jun 2010 14:50 On Mon, 2010-06-14 at 12:34 -0700, Andrew Morton wrote: > On Wed, 09 Jun 2010 12:56:50 -0400 > Davidlohr Bueso <dave.bueso(a)gmail.com> wrote: > > > If the last if condition passes the cdrom_mutex mutex will not be unlocked. > > This patch fixes this and also removes the unnecessary doit label that was only invoked by the done label. > > > > Confused. There is no way in which cdrom_sysctl_info() can forget to > unlock cdrom_mutex. > Ok, I had misread the code then, one of the reasons I don't like goto labels, but that's a different story. Regarding cdrom_sysctl_info(), I have noticed in several netbooks (haven't looked in other machines with no cdrom drive) that the /proc/sys/dev/cdrom/info file shows no values for the listed entries, ie: CD-ROM information, Id: cdrom.c 3.20 2003/12/17 drive name: drive speed: drive # of slots: Can close tray: Can open tray: .... Now, is this expected behavior? If not, should it be changed to something more descriptive? Perhaps it would affect user space applications that read the file? Thanks, Davidlohr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Andrew Morton on 15 Jun 2010 15:40
On Tue, 15 Jun 2010 14:40:54 -0400 Davidlohr Bueso <dave.bueso(a)gmail.com> wrote: > Regarding cdrom_sysctl_info(), I have noticed in several netbooks > (haven't > looked in other machines with no cdrom drive) that the > /proc/sys/dev/cdrom/info file shows no values for the listed entries, > ie: > > CD-ROM information, Id: cdrom.c 3.20 2003/12/17 > > drive name: > drive speed: > drive # of slots: > Can close tray: > Can open tray: > ... > > Now, is this expected behavior? If not, should it be changed to > something > more descriptive? Perhaps it would affect user space applications that > read > the file? It works for me. Does your kernel build have CONFIG_SYSCTL=n? If so, then all that code is disabled. That seems a bit bogus to me and perhaps we should enable at least some of that code by CONFIG_PROCFS instead. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |