usb gadget: don't save bind callback in struct usb_configuration
in [Kernel]
|
Prev: direct-io regression [Was: How to track down abysmal performance ata - raid1 - crypto - vg/lv - xfs]
Next: [PATCH 0/5 -mm][memcg] towards I/O aware memory cgroup v4
From: Uwe Kleine-König on 5 Aug 2010 05:50 On Thu, Aug 05, 2010 at 11:05:47AM +0200, Michał Nazarewicz wrote: > On Mon, 02 Aug 2010 20:27:46 +0200, Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> wrote: > >> The bind function is only called at init time so there is no need to >> save a pointer to it in the driver struct. > > This is not entirely true. How about such wording: > > The bind function is often called only at init time so there is no neet > to save a pointer to it in the configuration structure. OK. > Also note, that if you are fixing composite gadgets as well, there's also > usb_composite_driver structure and accompanying usb_composite_register() > function. This is ortogonal to my two patches, right? Will look into it later. Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Uwe Kleine-König on 6 Aug 2010 01:00
On Thu, Aug 05, 2010 at 03:34:35PM -0700, Greg KH wrote: > On Thu, Aug 05, 2010 at 11:50:17AM +0200, Uwe Kleine-König wrote: > > The bind function is most of the time only called at init time so there is no > > need to save a pointer to it in the configuration structure. > > > > This fixes many section mismatches reported by modpost. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> > > Cc: Michał Nazarewicz <m.nazarewicz(a)samsung.com> > > Cc: Greg Kroah-Hartman <gregkh(a)suse.de> > > --- > > changes since v1: > > I'm confused, can you resend what you want me to apply please? Will do. > Do I need to drop Michał's patch before applying yours? I double checked that now, and there is one thing in Michał's patch that is not fixed in mine. It's the hunk for drivers/usb/gadget/zero.c, as I didn't touch struct usb_composite_driver yet. So expect three patches in reply to this mail. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |