Prev: linux-next: manual merge of the staging-next tree with the v4l-dvb tree
Next: [RFC] perf migration
From: Nick Piggin on 7 Jul 2010 11:20
On Tue, Jun 15, 2010 at 10:42:53PM +0530, Aneesh Kumar K.V wrote:
> diff --git a/fs/open.c b/fs/open.c
> index 43ac798..1c5daa3 100644
> --- a/fs/open.c
> +++ b/fs/open.c
> @@ -1168,3 +1168,201 @@ SYSCALL_DEFINE4(name_to_handle_at, int, dfd, const char __user *, name,
> return -ENOSYS;
> }
> #endif
> +
> +#ifdef CONFIG_EXPORTFS
> +static struct vfsmount *get_vfsmount_from_fd(int fd)
> +{
> + int fput_needed;
> + struct path *path;
> + struct file *filep;
> +
> + if (fd == AT_FDCWD) {
> + struct fs_struct *fs = current->fs;
> + read_lock(&fs->lock);
> + path = &fs->pwd;
> + mntget(path->mnt);
> + read_unlock(&fs->lock);
> + } else {
> + filep = fget_light(fd, &fput_needed);
> + if (!filep)
> + return ERR_PTR(-EBADF);
> + path = &filep->f_path;
> + mntget(path->mnt);
> + fput_light(filep, fput_needed);
> + }
> + return path->mnt;
> +}

The bulk of this this should probably be in fs/namei.c, factored with
path_init stuff if possible please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Aneesh Kumar K. V on 7 Jul 2010 12:20
On Thu, 8 Jul 2010 01:17:38 +1000, Nick Piggin <npiggin(a)suse.de> wrote:
> On Tue, Jun 15, 2010 at 10:42:53PM +0530, Aneesh Kumar K.V wrote:
> > diff --git a/fs/open.c b/fs/open.c
> > index 43ac798..1c5daa3 100644
> > --- a/fs/open.c
> > +++ b/fs/open.c
> > @@ -1168,3 +1168,201 @@ SYSCALL_DEFINE4(name_to_handle_at, int, dfd, const char __user *, name,
> > return -ENOSYS;
> > }
> > #endif
> > +
> > +#ifdef CONFIG_EXPORTFS
> > +static struct vfsmount *get_vfsmount_from_fd(int fd)
> > +{
> > + int fput_needed;
> > + struct path *path;
> > + struct file *filep;
> > +
> > + if (fd == AT_FDCWD) {
> > + struct fs_struct *fs = current->fs;
> > + read_lock(&fs->lock);
> > + path = &fs->pwd;
> > + mntget(path->mnt);
> > + read_unlock(&fs->lock);
> > + } else {
> > + filep = fget_light(fd, &fput_needed);
> > + if (!filep)
> > + return ERR_PTR(-EBADF);
> > + path = &filep->f_path;
> > + mntget(path->mnt);
> > + fput_light(filep, fput_needed);
> > + }
> > + return path->mnt;
> > +}
>
> The bulk of this this should probably be in fs/namei.c, factored with
> path_init stuff if possible please.
>

Will move this to fs/namei.c. I guess we can also remove #ifdef
CONFIG_EXPORTFS around the code ?

-aneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: linux-next: manual merge of the staging-next tree with the v4l-dvb tree
Next: [RFC] perf migration