Prev: [PATCH] sysfs/file: move NULL checks to where they make sense and can occur
Next: [PATCH 2/2] staging: et131x: Fix brace coding style issues.
From: Dan Carpenter on 6 Mar 2010 06:10
Hi Dave,

drivers/gpu/vga/vga_switcheroo.c +362 vga_switcheroo_debugfs_write(101)
277 mutex_lock(&vgasr_mutex);
278
279 if (!vgasr_priv.active)
280 return -EINVAL;

Is there a reason we return with the lock held here? The other returns
from this function don't have the lock held. I looked through the rest
of the file but didn't see any clues.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] sysfs/file: move NULL checks to where they make sense and can occur
Next: [PATCH 2/2] staging: et131x: Fix brace coding style issues.