From: Minchan Kim on
On Tue, Jun 29, 2010 at 8:34 PM, Mel Gorman <mel(a)csn.ul.ie> wrote:
> From: Nick Piggin <npiggin(a)suse.de>
>
> Use lock_page_nosync in handle_write_error as after writepage we have no
> reference to the mapping when taking the page lock.
>
> Signed-off-by: Nick Piggin <npiggin(a)suse.de>
> Signed-off-by: Mel Gorman <mel(a)csn.ul.ie>

Trivial.
Please modify description of the function if you have a next turn.
"run sleeping lock_page()" -> "run sleeping lock_page_nosync"


--
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Johannes Weiner on
On Tue, Jun 29, 2010 at 12:34:35PM +0100, Mel Gorman wrote:
> From: Nick Piggin <npiggin(a)suse.de>
>
> Use lock_page_nosync in handle_write_error as after writepage we have no
> reference to the mapping when taking the page lock.
>
> Signed-off-by: Nick Piggin <npiggin(a)suse.de>
> Signed-off-by: Mel Gorman <mel(a)csn.ul.ie>

Reviewed-by: Johannes Weiner <hannes(a)cmpxchg.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Mel Gorman on
On Tue, Jun 29, 2010 at 11:27:05PM +0900, Minchan Kim wrote:
> On Tue, Jun 29, 2010 at 8:34 PM, Mel Gorman <mel(a)csn.ul.ie> wrote:
> > From: Nick Piggin <npiggin(a)suse.de>
> >
> > Use lock_page_nosync in handle_write_error as after writepage we have no
> > reference to the mapping when taking the page lock.
> >
> > Signed-off-by: Nick Piggin <npiggin(a)suse.de>
> > Signed-off-by: Mel Gorman <mel(a)csn.ul.ie>
>
> Trivial.
> Please modify description of the function if you have a next turn.
> "run sleeping lock_page()" -> "run sleeping lock_page_nosync"
>

Fixed, thanks.

--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/