vmscan: Remove useless loop at end of do_try_to_free_pages
in [Kernel]
|
Prev: net: mac8390 - Sort out memory/MMIO accesses and casts (was: Re: drivers/net/mac8390.c: Remove useless memcpy casting)
Next: vmscan: Remove unnecessary temporary vars in do_try_to_free_pages
From: KOSAKI Motohiro on 15 Apr 2010 22:50 > With the patch "vmscan: kill prev_priority completely", the loop at the > end of do_try_to_free_pages() is now doing nothing. Delete it. > > Signed-off-by: Mel Gorman <mel(a)csn.ul.ie> Obviously. thanks correct me. Reviewed-by: KOSAKI Motohiro <kosaki.motohiro(a)jp.fujitsu.com> > --- > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 76c2b03..838ac8b 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1806,11 +1806,6 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist, > ret = sc->nr_reclaimed; > > out: > - if (scanning_global_lru(sc)) > - for_each_zone_zonelist(zone, z, zonelist, high_zoneidx) > - if (!cpuset_zone_allowed_hardwall(zone, GFP_KERNEL)) > - continue; > - > delayacct_freepages_end(); > > return ret; > -- > 1.6.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Johannes Weiner on 16 Apr 2010 19:00
On Thu, Apr 15, 2010 at 06:21:37PM +0100, Mel Gorman wrote: > With the patch "vmscan: kill prev_priority completely", the loop at the > end of do_try_to_free_pages() is now doing nothing. Delete it. > > Signed-off-by: Mel Gorman <mel(a)csn.ul.ie> Reviewed-by: Johannes Weiner <hannes(a)cmpxchg.org> Maybe fold that into the prev_priority patch? :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |