vmscan: isolated_lru_pages() stop neighbor search if neighbor can't be isolated
in [Kernel]
|
Prev: [PATCH 2/3] MEMSTICK: fix hangs on unexpected device removal in mspro_blk
Next: [PATCH] driver core: device_rename's new_name can be const
From: Mel Gorman on 5 Aug 2010 11:30 On Thu, Aug 05, 2010 at 03:16:06PM +0900, KOSAKI Motohiro wrote: > isolate_lru_pages() doesn't only isolate LRU tail pages, but also > isolate neighbor pages of the eviction page. > > Now, the neighbor search don't stop even if neighbors can't be isolated. > It is silly. successful higher order allocation need full contenious > memory, even though only one page reclaim failure mean to fail making > enough contenious memory. > > Then, isolate_lru_pages() should stop to search PFN neighbor pages and > try to search next page on LRU soon. This patch does it. Also all of > lumpy reclaim failure account nr_lumpy_failed. > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro(a)jp.fujitsu.com> Seems reasonable. Acked-by: Mel Gorman <mel(a)csn.ul.ie> -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |