Prev: [PATCH v2] btrfs: set task state with schedule_timeout_uninterruptible()
Next: KVM: SVM: Emulate next_rip svm feature
From: John W. Linville on 27 Jul 2010 14:20
On Mon, Jul 26, 2010 at 02:40:00PM -0700, Joe Perches wrote:
> Save a few bytes of text
>
> (allyesconfig)
> $ size drivers/net/wireless/built-in.o*
> text data bss dec hex filename
> 3924568 100548 871056 4896172 4ab5ac drivers/net/wireless/built-in.o.new
> 3926520 100548 871464 4898532 4abee4 drivers/net/wireless/built-in.o.old
>
> $ size net/wireless/core.o*
> text data bss dec hex filename
> 12843 216 3768 16827 41bb net/wireless/core.o.new
> 12328 216 3656 16200 3f48 net/wireless/core.o
>
> Signed-off-by: Joe Perches <joe(a)perches.com>

> --- a/net/wireless/core.c
> +++ b/net/wireless/core.c
> @@ -907,3 +907,56 @@ static void __exit cfg80211_exit(void)
> destroy_workqueue(cfg80211_wq);
> }
> module_exit(cfg80211_exit);
> +
> +#ifdef __KERNEL__

Do we need this part?

--
John W. Linville Someday the world will need a hero, and you
linville(a)tuxdriver.com might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Joe Perches on 27 Jul 2010 14:40
On Tue, 2010-07-27 at 14:05 -0400, John W. Linville wrote:
> > --- a/net/wireless/core.c
> > +++ b/net/wireless/core.c
> > @@ -907,3 +907,56 @@ static void __exit cfg80211_exit(void)
> > destroy_workqueue(cfg80211_wq);
> > }
> > module_exit(cfg80211_exit);
> > +
> > +#ifdef __KERNEL__
>
> Do we need this part?

No, not really.

I'm not too sure about the need for the added
cfg80211.h #ifdef __KERNEL__ either.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: John W. Linville on 27 Jul 2010 15:10
On Tue, Jul 27, 2010 at 11:34:25AM -0700, Joe Perches wrote:
> On Tue, 2010-07-27 at 14:05 -0400, John W. Linville wrote:
> > > --- a/net/wireless/core.c
> > > +++ b/net/wireless/core.c
> > > @@ -907,3 +907,56 @@ static void __exit cfg80211_exit(void)
> > > destroy_workqueue(cfg80211_wq);
> > > }
> > > module_exit(cfg80211_exit);
> > > +
> > > +#ifdef __KERNEL__
> >
> > Do we need this part?
>
> No, not really.
>
> I'm not too sure about the need for the added
> cfg80211.h #ifdef __KERNEL__ either.

Good point -- I'll remove both of them.

John
--
John W. Linville Someday the world will need a hero, and you
linville(a)tuxdriver.com might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH v2] btrfs: set task state with schedule_timeout_uninterruptible()
Next: KVM: SVM: Emulate next_rip svm feature