Prev: regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write()
Next: [PATCH] serial: Add CONSOLE_POLL support for uartlite
From: Tejun Heo on 9 Aug 2010 06:00
Hello,

On 08/09/2010 11:46 AM, Markus Trippelsdorf wrote:
> This fixes the boot problem here. Thanks.

Great. May I add your Tested-by?

> (The drm delayed enqueue problem, which I mentioned earlier still
> persists.)

Yeah, I'm looking into it now but it looks like the error message is
simply spurious. queue_delayed_work() returns 1 if the work was
actually queued and 0 if it was already pending and thus the function
call was no-op. output_poll_execute() is incorrectly interpreting 1
return as error. I'll look through the history and try to find out
whether/how wq changes affected the behavior, but the fix is most
likely simply killing the message.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: walt on 9 Aug 2010 10:20
On 08/09/2010 02:36 AM, Tejun Heo wrote:
> Commit 6ee0578b (workqueue: mark init_workqueues as early_initcall)
> made workqueue SMP initialization depend on workqueue_cpu_callback(),
> which however was registered as hotcpu_notifier() and didn't get
> called if CONFIG_HOTPLUG_CPU is not set. This made gcwqs on non-boot
> CPUs not create their initial workers leading to boot failures. Fix
> it by making it a cpu_notifier.
> ---
> So, something like this. Can you please verify the fix?

>
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index da6c482..2994a0e 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -3527,7 +3527,7 @@ static int __init init_workqueues(void)
> unsigned int cpu;
> int i;
>
> - hotcpu_notifier(workqueue_cpu_callback, CPU_PRI_WORKQUEUE);
> + cpu_notifier(workqueue_cpu_callback, CPU_PRI_WORKQUEUE);

This fixes the hang during boot for me too, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write()
Next: [PATCH] serial: Add CONSOLE_POLL support for uartlite