Prev: arch/arm: Fix missing define for ARM_PMU_DEVICE_CPU
Next: ***IMPORTANT NOTICE***
From: Ingo Molnar on 30 Apr 2010 14:40

* Thomas Renninger <trenn(a)suse.de> wrote:

> + trace_power_start(POWER_CSTATE, 1, smp_processor_id());
> + trace_power_start(POWER_CSTATE, (ax>>4)+1, smp_processor_id());
> + trace_power_start(POWER_CSTATE, 1, smp_processor_id());
> + trace_power_start(POWER_CSTATE, 0, smp_processor_id());
> + trace_power_frequency(POWER_PSTATE, freqs->new, freqs->cpu);
> + trace_power_end(smp_processor_id());

Extending power tracing to all cpufreq modules is obviously a good thing.

But why is trace_power_start() adding a CPU ID argument? CPU ids are already
available and can be sampled via PERF_SAMPLE_CPU if needed. AFAICS only
power_frequency needs a new 'target_cpu_id' field.

> diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c
> index 0d4d8ff..7809bef 100644
> --- a/tools/perf/builtin-timechart.c
> +++ b/tools/perf/builtin-timechart.c

Timechart is maintained by Arjan so we need an ack from him as well. I've seen
some back and forth in the discussions - what's the technical resolution of
that?

(Also, there's some whitespace noise in the patch.)

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: arch/arm: Fix missing define for ARM_PMU_DEVICE_CPU
Next: ***IMPORTANT NOTICE***