From: Simon Holm Thøgersen on
tor, 19 06 2008 kl. 17:13 +0200, skrev Ingo Molnar:
> Linus,
>
> please pull the latest x86 fixes git tree from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git x86-fixes-for-linus
>

> Suresh Siddha (1):
> x86: fix NULL pointer deref in __switch_to

Ingo, Rusty and Suresh

This doesn't contain the lguest part of the fix that Patrick and I
reported were necessary to fix the problem we reported. Is this being
pushed via another path?


Simon Holm Thøgersen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Suresh Siddha on
On Thu, Jun 19, 2008 at 02:29:46PM -0700, Simon Holm Th�gersen wrote:
> tor, 19 06 2008 kl. 17:13 +0200, skrev Ingo Molnar:
> > Linus,
> >
> > please pull the latest x86 fixes git tree from:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git x86-fixes-for-linus
> >
>
> > Suresh Siddha (1):
> > x86: fix NULL pointer deref in __switch_to
>
> Ingo, Rusty and Suresh
>
> This doesn't contain the lguest part of the fix that Patrick and I
> reported were necessary to fix the problem we reported. Is this being
> pushed via another path?

Simon, Yes. Ingo is going to push the missing pieces with another patch.

thanks,
suresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Linus Torvalds on


On Tue, 15 Jul 2008, Ingo Molnar wrote:
>
> hm, you just pushed another fix for that out via:
> [...]
> that would collide. Here's a (separate) merged up tree that will pull
> cleanly:

Heh, I just merged it myself - it happens all the time, I did't even think
about it.

If it had been any more complex I would have emailed you (and hopefully
noticed this follow-up email before doing that), but it was rather obvious
enough, and I just picked your side.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Johannes Weiner on
Hi,

Ingo Molnar <mingo(a)elte.hu> writes:

> Linus,
>
> Please pull the latest x86 fixes git tree from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git x86-fixes-for-linus
>
> Thanks,
>
> Ingo
>
> ------------------>
> Jan Kratochvil (1):
> x86: fix crash due to missing debugctlmsr on AMD K6-3
>
> Jeremy Fitzhardinge (2):
> x86: rename PTE_MASK to PTE_PFN_MASK
> x86: add PTE_FLAGS_MASK

Are you serious? It goes _this_ fast? The patch came into my mbox at
8:00am this morning and you push it to Linus at 4:00pm already?

What about the inconsistency it introduces? When I look at PAGE_MASK
for example, it masks out the PAGE offset. PTE_MASK masks out PTE
specifca from a value.

Now, I assume PTE_PFN_MASK masks out the PFN. Oh, wait, it masks the
protection bits.

Why not wait a bit longer before pushing things into mainline?

Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Jeremy Fitzhardinge on
Johannes Weiner wrote:
> Hi,
>
> Ingo Molnar <mingo(a)elte.hu> writes:
>
>
>> Linus,
>>
>> Please pull the latest x86 fixes git tree from:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git x86-fixes-for-linus
>>
>> Thanks,
>>
>> Ingo
>>
>> ------------------>
>> Jan Kratochvil (1):
>> x86: fix crash due to missing debugctlmsr on AMD K6-3
>>
>> Jeremy Fitzhardinge (2):
>> x86: rename PTE_MASK to PTE_PFN_MASK
>> x86: add PTE_FLAGS_MASK
>>
>
> Are you serious? It goes _this_ fast? The patch came into my mbox at
> 8:00am this morning and you push it to Linus at 4:00pm already?
>
> What about the inconsistency it introduces? When I look at PAGE_MASK
> for example, it masks out the PAGE offset. PTE_MASK masks out PTE
> specifca from a value.
>
> Now, I assume PTE_PFN_MASK masks out the PFN. Oh, wait, it masks the
> protection bits.

PAGE_MASK turns an address into its page address.

PTE_PFN_MASK takes a pte value and returns the pte's pfn portion (which
is shifted so it's actually a page address).

In both cases, the X_MASK terminology means that X is extracted, not
excluded. Which makes sense; if you have a packed bitfield containing
multiple values, you wouldn't expect X to be the list of things *not*
extracted.

(I would be happy to have a PAGE_OFFSET_MASK for all the places where
you want to extract the offset.)

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/