x86,io-apic: Do not map IO-APIC direct registers twice
in [Kernel]
|
Prev: build issue #34 for v2.6.32-rc6-346-gaa021ba :ERROR: "log_start_commit" [fs/ext3/ext3.ko] undefined!
Next: vmscan: Stop kswapd waiting on congestion when the min watermark is not being met
From: Cyrill Gorcunov on 12 Nov 2009 16:00 On Thu, Nov 12, 2009 at 11:48:52PM +0300, Cyrill Gorcunov wrote: > Please review, I didn't manage to test (emulate actually since I don't > have such a hardware) it yet (going to do so this weekend). > > Meanwhile I would like to heard comments, complains and etc... > Perhaps I miss something obvious so don't hesitate to poke me. > > -- Cyrill > --- > x86,io-apic: Do not map IO-APIC direct registers twice > .... I know that I've occasionally removed apic_printk(APIC_VERBOSE, "mapped IOAPIC to %08lx (%08lx)\n", already fixed in v2, just do not post updated version here. -- Cyrill -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Cyrill Gorcunov on 12 Nov 2009 16:10 On Thu, Nov 12, 2009 at 11:54:59PM +0300, Cyrill Gorcunov wrote: > On Thu, Nov 12, 2009 at 11:48:52PM +0300, Cyrill Gorcunov wrote: > > Please review, I didn't manage to test (emulate actually since I don't > > have such a hardware) it yet (going to do so this weekend). > > > > Meanwhile I would like to heard comments, complains and etc... > > Perhaps I miss something obvious so don't hesitate to poke me. > > > > -- Cyrill > > --- > > x86,io-apic: Do not map IO-APIC direct registers twice > > > ... > I know that I've occasionally removed > > apic_printk(APIC_VERBOSE, "mapped IOAPIC > to %08lx (%08lx)\n", > > already fixed in v2, just do not post updated version here. > > -- Cyrill Forgot to mention that I know this double for() over nr_ioapics is slowlest approach but firstly I need to be sure that this idea works in general/simple way before speedup it. -- Cyrill -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Cyrill Gorcunov on 13 Nov 2009 14:20
On Fri, Nov 13, 2009 at 10:56:35AM -0800, Yinghai Lu wrote: > Cyrill Gorcunov wrote: > > On Thu, Nov 12, 2009 at 03:22:55PM -0800, Yinghai Lu wrote: > >> Cyrill Gorcunov wrote: > >>> Please review, I didn't manage to test (emulate actually since I don't > >>> > > ... > > > > First of all -- thanks a lot for review Yinghai! > > > >>> Also insert_resourse will not fail anymore on 1K aligned io-apics. > >> looks that we don't need that ... > >> not io_apic_base already have that + &. left problems are > >> 1. display. > >> 2. insert resource problem. > >> > >> YH > >> > >> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c > >> index 90e8bc5..6a9379b 100644 > >> --- a/arch/x86/kernel/apic/io_apic.c > >> +++ b/arch/x86/kernel/apic/io_apic.c > >> @@ -4140,11 +4140,13 @@ fake_ioapic_page: > >> set_fixmap_nocache(idx, ioapic_phys); > >> apic_printk(APIC_VERBOSE, > >> "mapped IOAPIC to %08lx (%08lx)\n", > >> - __fix_to_virt(idx), ioapic_phys); > >> + __fix_to_virt(idx) + (ioapic_phys & ~PAGE_MASK), > > > > Don't understand, why? What is wrong with physical address, > > could you elaborate please? > > ioapic_phys could be 1k aligned, but __fix_to_virt(idx) will always return 4k aligned. yeah, I just misread your patch, I thought you've changed second argument, sorry. OK, I see what you mean, good catch, thanks! > > > > >> + ioapic_phys); > >> idx++; > >> > >> + /* spec says size is 1024 */ > > > > Hmm, MP says nothing about size of IO-APIC direct registers > > cound and as a result -- the size of MMIO. It will (and > > is) differ between IO-APIC versions. An example -- IO-APIC EOI register > > which 82489DX just dont have at all. At moment (ICH-10) the lenght is 68 > > bytes so you may note the comment in the former patch that we "hope" such > > a size will be enough for quite a long time to cover all direct register > > space an IO-APIC provides (though to be precise from this 68 bytes only > > index,data,eoi registers specified). > > > >> ioapic_res->start = ioapic_phys; > >> - ioapic_res->end = ioapic_phys + PAGE_SIZE-1; > >> + ioapic_res->end = ioapic_phys + (1<<10) - 1; > >> ioapic_res++; > >> } > >> } > >> > > > > I think I've compicated the patch/idea too much indeed :) > > Since we have fixmap for all io_apics build time reserved > > even if some io-apic is 1K aligned we still may use new > > fixmap index. So only issue remains -- resource allocation. > > Here is an updated patch. Please review. > > 2. print out ...? Print out what? Not sure I understand you right. Perhaps you mean to check insert_resourse results? > > YH > -- Cyrill -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |