Prev: [GIT PULL] Ptrace bkl removal for 2.6.35-rc1
Next: [PATCH] Fix uninitialized spinlock of printk_ratelimited()
From: Thomas Gleixner on 16 May 2010 19:00
On Fri, 14 May 2010, Jacob Pan wrote:
>
> -/*
> - * the secondary clock in Moorestown can be APBT or LAPIC clock, default to
> - * APBT but cmdline option can also override it.
> - */
> static void __cpuinit mrst_setup_secondary_clock(void)
> {
> - /* restore default lapic clock if disabled by cmdline */
> - if (disable_apbt_percpu)
> - return setup_secondary_APIC_clock();
> + if ((mrst_timer_options == MRST_TIMER_APBT_ONLY))
> + return apbt_setup_secondary_clock();

Did you compile this ?

> + if (cpu_has(&current_cpu_data, X86_FEATURE_ARAT)
> + || (mrst_timer_options == MRST_TIMER_LAPIC_APBT)) {
> + pr_info("using lapic timers for secondary clock\n");
> + setup_secondary_APIC_clock();
> + return;
> + }

As I said before, this function sucks. The decision logic is just
obscure. It's not rocket science to make it understandable.

> apbt_setup_secondary_clock();
> }

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [GIT PULL] Ptrace bkl removal for 2.6.35-rc1
Next: [PATCH] Fix uninitialized spinlock of printk_ratelimited()