Prev: sparc: use asm-generic/pci-dma-common.h
Next: [patch v2 0/4] updated ptrace/core-dump patches for supporting xstate - V2
From: Andrew Morton on 9 Feb 2010 15:00
On Tue, 09 Feb 2010 11:32:15 -0800
Yinghai Lu <yinghai(a)kernel.org> wrote:

> --- a/arch/x86/pci/amd_bus.c
> +++ b/arch/x86/pci/amd_bus.c
> @@ -87,11 +87,12 @@ static int __init early_fill_mp_bus_info(void)
> struct range range[RANGE_NUM];
> u64 val;
> u32 address;
> + int found;

It'd be clearer to give this the `bool' type. After all, it's a bool.

>
> if (!early_pci_allowed())
> return -1;
>
> - found_all_numa_early = 0;
> + found = 0;
> for (i = 0; i < ARRAY_SIZE(pci_probes); i++) {
> u32 id;
> u16 device;
> @@ -105,12 +106,12 @@ static int __init early_fill_mp_bus_info(void)
> device = (id>>16) & 0xffff;
> if (pci_probes[i].vendor == vendor &&
> pci_probes[i].device == device) {
> - found_all_numa_early = 1;
> + found = 1;
> break;
> }
> }
>
> - if (!found_all_numa_early)
> + if (!found)
> return 0;
>
> pci_root_num = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: sparc: use asm-generic/pci-dma-common.h
Next: [patch v2 0/4] updated ptrace/core-dump patches for supporting xstate - V2