From: H. Peter Anvin on
On 07/15/2010 03:27 PM, Yinghai Lu wrote:
>
> to save the early_serial_base.
>
> Also bootloader could fill that field, so setup code could reuse it.
>
> decompress code could reuse early serial console from setup code.
>
> Signed-off-by: Yinghai Lu <yinghai(a)kernel.org>
>

What's the point with this over what we currently have?

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Yinghai Lu on
On 07/15/2010 05:12 PM, H. Peter Anvin wrote:
> On 07/15/2010 03:27 PM, Yinghai Lu wrote:
>>
>> to save the early_serial_base.
>>
>> Also bootloader could fill that field, so setup code could reuse it.
>>
>> decompress code could reuse early serial console from setup code.
>>
>> Signed-off-by: Yinghai Lu <yinghai(a)kernel.org>
>>
>
> What's the point with this over what we currently have?

extend serial console coverage to boot/compressed/misc.c

before this one, we have cover in boot/*.c only.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Cyrill Gorcunov on
On Thu, Jul 15, 2010 at 03:27:18PM -0700, Yinghai Lu wrote:
>
> to save the early_serial_base.
>
> Also bootloader could fill that field, so setup code could reuse it.
>
> decompress code could reuse early serial console from setup code.
>
> Signed-off-by: Yinghai Lu <yinghai(a)kernel.org>
>

Hi Yinghai, sorry for delayed response. I like the idea much since it'll allow
to log decompressor messages in case if someone would be changing exitsting code
or developing new one, though this touches boot protocol so that grub/syslinux
and friends will have to update their code as well which of course need some
time.

-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: H. Peter Anvin on
On 07/31/2010 01:34 AM, Cyrill Gorcunov wrote:
> On Thu, Jul 15, 2010 at 03:27:18PM -0700, Yinghai Lu wrote:
>>
>> to save the early_serial_base.
>>
>> Also bootloader could fill that field, so setup code could reuse it.
>>
>> decompress code could reuse early serial console from setup code.
>>
>> Signed-off-by: Yinghai Lu <yinghai(a)kernel.org>
>>
>
> Hi Yinghai, sorry for delayed response. I like the idea much since it'll allow
> to log decompressor messages in case if someone would be changing exitsting code
> or developing new one, though this touches boot protocol so that grub/syslinux
> and friends will have to update their code as well which of course need some
> time.
>

No, this is the internal part of the boot protocol, so it's not an issue.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Cyrill Gorcunov on
On Sat, Jul 31, 2010 at 11:21:35AM -0700, H. Peter Anvin wrote:
> On 07/31/2010 01:34 AM, Cyrill Gorcunov wrote:
> > On Thu, Jul 15, 2010 at 03:27:18PM -0700, Yinghai Lu wrote:
> >>
> >> to save the early_serial_base.
> >>
> >> Also bootloader could fill that field, so setup code could reuse it.
> >>
> >> decompress code could reuse early serial console from setup code.
> >>
> >> Signed-off-by: Yinghai Lu <yinghai(a)kernel.org>
> >>
> >
> > Hi Yinghai, sorry for delayed response. I like the idea much since it'll allow
> > to log decompressor messages in case if someone would be changing exitsting code
> > or developing new one, though this touches boot protocol so that grub/syslinux
> > and friends will have to update their code as well which of course need some
> > time.
> >
>
> No, this is the internal part of the boot protocol, so it's not an issue.
>

Peter, I didn't mean any issue here, I meant that bootloaders don't know about
this field yet and they will have to update own sources to pass port value
at proper place of boot params. Or I miss something?

> -hpa
>
-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/