xfs: fix unsigned underflow
in [Kernel]
|
Prev: Linux 2.6.28.10 and Linux 2.6.29.6 XEN Guest Support Broken x86_64 in BUILD
Next: video/ivtv: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
From: Christoph Hellwig on 15 Jul 2010 17:30 On Thu, Jul 15, 2010 at 10:46:45PM +0400, Kulikov Vasiliy wrote: > map_len is unsigned. Checking map_len <= 0 is buggy when it should be > below zero. So, check exact expression instead of map_len. > > Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com> Looks good, Reviewed-by: Christoph Hellwig <hch(a)lst.de> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Alex Elder on 20 Jul 2010 15:40 On Thu, 2010-07-15 at 17:21 -0400, Christoph Hellwig wrote: > On Thu, Jul 15, 2010 at 10:46:45PM +0400, Kulikov Vasiliy wrote: > > map_len is unsigned. Checking map_len <= 0 is buggy when it should be > > below zero. So, check exact expression instead of map_len. > > > > Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com> > > Looks good, > > Reviewed-by: Christoph Hellwig <hch(a)lst.de> > Looks good to me too. Do you want me to pull this in via the XFS tree, or do you have other plans? -Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Vasiliy Kulikov on 20 Jul 2010 16:30 On Tue, Jul 20, 2010 at 14:35 -0500, Alex Elder wrote: > On Thu, 2010-07-15 at 17:21 -0400, Christoph Hellwig wrote: > > On Thu, Jul 15, 2010 at 10:46:45PM +0400, Kulikov Vasiliy wrote: > > > map_len is unsigned. Checking map_len <= 0 is buggy when it should be > > > below zero. So, check exact expression instead of map_len. > > > > > > Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com> > > > > Looks good, > > > > Reviewed-by: Christoph Hellwig <hch(a)lst.de> > > > > Looks good to me too. Do you want me to pull this > in via the XFS tree, or do you have other plans? Yes, pull it please. > > -Alex > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Dave Chinner on 20 Jul 2010 19:20
On Tue, Jul 20, 2010 at 02:35:33PM -0500, Alex Elder wrote: > On Thu, 2010-07-15 at 17:21 -0400, Christoph Hellwig wrote: > > On Thu, Jul 15, 2010 at 10:46:45PM +0400, Kulikov Vasiliy wrote: > > > map_len is unsigned. Checking map_len <= 0 is buggy when it should be > > > below zero. So, check exact expression instead of map_len. > > > > > > Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com> > > > > Looks good, > > > > Reviewed-by: Christoph Hellwig <hch(a)lst.de> > > > > Looks good to me too. Do you want me to pull this > in via the XFS tree, or do you have other plans? Already got it, Alex. Cheers, Dave. -- Dave Chinner david(a)fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |