From: Sedat Dilek on
Hi Rafael,

On Fri, Jul 9, 2010 at 1:33 AM, Rafael J. Wysocki <rjw(a)sisk.pl> wrote:
[...]
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16169
Subject : Complain from preemptive debug
Submitter : Sedat Dilek <sedat.dilek(a)googlemail.com>
Date : 2010-05-31 10:10 (39 days old)
Message-ID : <AANLkTilTnAAZIizKinYsxFkNTkrmPqk6XJJuUjjhJ7EP(a)mail.gmail.com>
References : http://lkml.org/lkml/2010/5/31/77
Handled-By : Dmitry Monakhov <dmonakhov(a)openvz.org>
Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>
Patch : http://www.spinics.net/lists/cpufreq/msg01631.html
https://patchwork.kernel.org/patch/106555/

This bug is fixed Upstream [1]:

commit 8c215bd3890c347dfb6a2db4779755f8b9c298a9
"sched: Cure nr_iowait_cpu() users"

- Sedat -

[1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=8c215bd3890c347dfb6a2db4779755f8b9c298a9
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on
From: Linus Torvalds <torvalds(a)linux-foundation.org>
Date: Thu, 8 Jul 2010 18:34:25 -0700

> On Thu, Jul 8, 2010 at 4:33 PM, Rafael J. Wysocki <rjw(a)sisk.pl> wrote:
>>
>> Bug-Entry � � � : http://bugzilla.kernel.org/show_bug.cgi?id=16187
>> Subject � � � � : Carrier detection failed in dhcpcd when link is up
>> Submitter � � � : Christian Casteyde <casteyde.christian(a)free.fr>
>> Date � � � � � �: 2010-06-12 15:15 (27 days old)
>> First-Bad-Commit: http://git.kernel.org/linus/10708f37ae729baba9b67bd134c3720709d4ae62
>> Handled-By � � �: Andrew Morton <akpm(a)linux-foundation.org>
>
> David? This bisects to a networking commit. Doesn't look sensible, but
> what do I know?

My suspicion is that dhcpd uses netlink to dump the info of the
available links, and due to some bug gets confused with the new 64-bit
statistic netlink attribute being there now.

That shouldn't happen, applications should just ignore the attributes
which they don't understand.

I'll try to find a second to have a look at this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Eric Dumazet on
Le jeudi 08 juillet 2010 à 21:34 -0700, David Miller a écrit :
> From: Linus Torvalds <torvalds(a)linux-foundation.org>
> Date: Thu, 8 Jul 2010 18:34:25 -0700
>
> > On Thu, Jul 8, 2010 at 4:33 PM, Rafael J. Wysocki <rjw(a)sisk.pl> wrote:
> >>
> >> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16187
> >> Subject : Carrier detection failed in dhcpcd when link is up
> >> Submitter : Christian Casteyde <casteyde.christian(a)free.fr>
> >> Date : 2010-06-12 15:15 (27 days old)
> >> First-Bad-Commit: http://git.kernel.org/linus/10708f37ae729baba9b67bd134c3720709d4ae62
> >> Handled-By : Andrew Morton <akpm(a)linux-foundation.org>
> >
> > David? This bisects to a networking commit. Doesn't look sensible, but
> > what do I know?
>
> My suspicion is that dhcpd uses netlink to dump the info of the
> available links, and due to some bug gets confused with the new 64-bit
> statistic netlink attribute being there now.
> a second to have a look at this.

It could be a dhcpcd bug because of extended size of answer

According to strace, dhcpcd tries a recvmsg() call with
a 256 bytes buffer to hold answer.

Looking at current dhcpcd source, I confirm it cannot realloc its buffer

static int
get_netlink(int fd, int flags,
int (*callback)(struct nlmsghdr *))
{
char *buffer = NULL;
ssize_t bytes;
struct nlmsghdr *nlm;
int r = -1;

buffer = xzalloc(sizeof(char) * BUFFERLEN);
for (;;) {
bytes = recv(fd, buffer, BUFFERLEN, flags);
if (bytes == -1) {
if (errno == EAGAIN) {
r = 0;
goto eexit;
}
if (errno == EINTR)
continue;
goto eexit;
}


This program needs to fix this.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on
From: Eric Dumazet <eric.dumazet(a)gmail.com>
Date: Fri, 09 Jul 2010 07:28:54 +0200

> Le jeudi 08 juillet 2010 � 21:34 -0700, David Miller a �crit :
>> From: Linus Torvalds <torvalds(a)linux-foundation.org>
>> Date: Thu, 8 Jul 2010 18:34:25 -0700
>>
>> > On Thu, Jul 8, 2010 at 4:33 PM, Rafael J. Wysocki <rjw(a)sisk.pl> wrote:
>> >>
>> >> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16187
>> >> Subject : Carrier detection failed in dhcpcd when link is up
>> >> Submitter : Christian Casteyde <casteyde.christian(a)free.fr>
>> >> Date : 2010-06-12 15:15 (27 days old)
>> >> First-Bad-Commit: http://git.kernel.org/linus/10708f37ae729baba9b67bd134c3720709d4ae62
>> >> Handled-By : Andrew Morton <akpm(a)linux-foundation.org>
>> >
>> > David? This bisects to a networking commit. Doesn't look sensible, but
>> > what do I know?
>>
>> My suspicion is that dhcpd uses netlink to dump the info of the
>> available links, and due to some bug gets confused with the new 64-bit
>> statistic netlink attribute being there now.
>> a second to have a look at this.
>
> It could be a dhcpcd bug because of extended size of answer
>
> According to strace, dhcpcd tries a recvmsg() call with
> a 256 bytes buffer to hold answer.
>
> Looking at current dhcpcd source, I confirm it cannot realloc its buffer
...
> This program needs to fix this.

Agreed, I don't there is any reasonable way we could cater to this
application bug with some compatability bits. Restricting the link
dump to 256 bytes is just too much inflexibility.

If NetworkManager can get this right, dhcpd very well can too :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Enrico Bandiello on
On 07/09/2010 05:41 PM, Enrico Bandiello wrote:

> Well... Let me try; being the firts time I send a bug report I've just
> to learn how to do this kind of stuff. In this moment I'm compiling -rc4
> to see if the "problem" persists. After, I'll try to go on with bisecting.

Same "problem" with -rc4...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/