From: Kees Cook on
Hi Rafael,

On Fri, Jul 09, 2010 at 01:41:39AM +0200, Rafael J. Wysocki wrote:
> The following bug entry is on the current list of known regressions
> from 2.6.34. Please verify if it still should be listed and let the tracking team
> know (either way).

Yup, this is still a regression. The fix is trivial (see below).

> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16294
> Subject : [Q35 bisected] hang at init of i915 driver
> Submitter : Kees Cook <kees(a)outflux.net>
> Date : 2010-06-25 18:20 (14 days old)
> First-Bad-Commit: http://git.kernel.org/linus/f1befe71fa7a79ab733011b045639d8d809924ad

diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c
index 9344216..0d9007d 100644
--- a/drivers/char/agp/intel-gtt.c
+++ b/drivers/char/agp/intel-gtt.c
@@ -1229,6 +1229,7 @@ static int intel_i915_get_gtt_size(void)
(gmch_ctrl & G33_PGETBL_SIZE_MASK));
size = 512;
}
+ size = 1024;
} else {
/* On previous hardware, the GTT size was just what was
* required to map the aperture.

--
Kees Cook @outflux.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Rafael J. Wysocki on
On Friday, July 09, 2010, Kees Cook wrote:
> Hi Rafael,
>
> On Fri, Jul 09, 2010 at 01:41:39AM +0200, Rafael J. Wysocki wrote:
> > The following bug entry is on the current list of known regressions
> > from 2.6.34. Please verify if it still should be listed and let the tracking team
> > know (either way).
>
> Yup, this is still a regression. The fix is trivial (see below).

Thanks for the update.

> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16294
> > Subject : [Q35 bisected] hang at init of i915 driver
> > Submitter : Kees Cook <kees(a)outflux.net>
> > Date : 2010-06-25 18:20 (14 days old)
> > First-Bad-Commit: http://git.kernel.org/linus/f1befe71fa7a79ab733011b045639d8d809924ad
>
> diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c
> index 9344216..0d9007d 100644
> --- a/drivers/char/agp/intel-gtt.c
> +++ b/drivers/char/agp/intel-gtt.c
> @@ -1229,6 +1229,7 @@ static int intel_i915_get_gtt_size(void)
> (gmch_ctrl & G33_PGETBL_SIZE_MASK));
> size = 512;
> }
> + size = 1024;
> } else {
> /* On previous hardware, the GTT size was just what was
> * required to map the aperture.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Tim Gardner on
On 07/23/2010 01:47 PM, Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a summary report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.34. Please verify if it still should be listed and let the tracking team
> know (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16294
> Subject : [Q35 bisected] hang at init of i915 driver
> Submitter : Kees Cook<kees(a)outflux.net>
> Date : 2010-06-25 18:20 (29 days old)
> First-Bad-Commit: http://git.kernel.org/linus/f1befe71fa7a79ab733011b045639d8d809924ad
> Handled-By : Tim Gardner<tim.gardner(a)canonical.com>
> Patch : https://patchwork.kernel.org/patch/111130/
>
>

There is a patch attached to the BZ report that has been ack'd by a
couple of testers as well as by the original committer. I've been told
that it should go through Eric Anholt instead of Dave Arlie, but Eric
has yet to respond.

Acked-by and Tested-by included in this thread:
http://lkml.org/lkml/2010/7/21/278

rtg
--
Tim Gardner tim.gardner(a)canonical.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Kees Cook on
Hi Rafael,

On Fri, Jul 23, 2010 at 01:47:30PM +0200, Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a summary report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.34. Please verify if it still should be listed and let the tracking team
> know (either way).

The regression still exists[1] in the mainline kernel -- the confirmed fix
mentioned below has not been committed.

> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16294
> Subject : [Q35 bisected] hang at init of i915 driver
> Submitter : Kees Cook <kees(a)outflux.net>
> Date : 2010-06-25 18:20 (29 days old)
> First-Bad-Commit: http://git.kernel.org/linus/f1befe71fa7a79ab733011b045639d8d809924ad
> Handled-By : Tim Gardner <tim.gardner(a)canonical.com>
> Patch : https://patchwork.kernel.org/patch/111130/

Thanks,

-Kees

[1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=history;f=drivers/char/agp/intel-gtt.c;h=HEAD

--
Kees Cook
Ubuntu Security Team
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Rafael J. Wysocki on
On Friday, July 23, 2010, Tim Gardner wrote:
> On 07/23/2010 01:47 PM, Rafael J. Wysocki wrote:
> > This message has been generated automatically as a part of a summary report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.34. Please verify if it still should be listed and let the tracking team
> > know (either way).
> >
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16294
> > Subject : [Q35 bisected] hang at init of i915 driver
> > Submitter : Kees Cook<kees(a)outflux.net>
> > Date : 2010-06-25 18:20 (29 days old)
> > First-Bad-Commit: http://git.kernel.org/linus/f1befe71fa7a79ab733011b045639d8d809924ad
> > Handled-By : Tim Gardner<tim.gardner(a)canonical.com>
> > Patch : https://patchwork.kernel.org/patch/111130/
> >
> >
>
> There is a patch attached to the BZ report that has been ack'd by a
> couple of testers as well as by the original committer. I've been told
> that it should go through Eric Anholt instead of Dave Arlie, but Eric
> has yet to respond.

Eric?

> Acked-by and Tested-by included in this thread:
> http://lkml.org/lkml/2010/7/21/278

Thanks for the update.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/