Prev: [46/89] fnctl: f_modown should call write_lock_irqsave/restore
Next: [52/89] i2c-tiny-usb: Fix on big-endian systems
From: Greg KH on 30 Mar 2010 20:30
2.6.31-stable review patch. If anyone has any objections, please let us know.

------------------

commit 85f8d3e5faea8bd36c3e5196f8334f7db45e19b2 upstream.

The #define ADT7462_VOLT_COUNT is wrong, it should be 13 not 12. All the
for loops that use this as a limit count are of the typical form, "for
(n = 0; n < ADT7462_VOLT_COUNT; n++)", so to loop through all voltages
w/o missing the last one it is necessary for the count to be one greater
than it is. (Specifically, you will miss the +1.5V 3GPIO input with count
= 12 vs. 13.)

Signed-off-by: Ray Copeland <ray.copeland(a)aprius.com>
Acked-by: "Darrick J. Wong" <djwong(a)us.ibm.com>
Signed-off-by: Jean Delvare <khali(a)linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de>
---
drivers/hwmon/adt7462.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/hwmon/adt7462.c
+++ b/drivers/hwmon/adt7462.c
@@ -182,7 +182,7 @@ I2C_CLIENT_INSMOD_1(adt7462);
*
* Some, but not all, of these voltages have low/high limits.
*/
-#define ADT7462_VOLT_COUNT 12
+#define ADT7462_VOLT_COUNT 13

#define ADT7462_VENDOR 0x41
#define ADT7462_DEVICE 0x62


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [46/89] fnctl: f_modown should call write_lock_irqsave/restore
Next: [52/89] i2c-tiny-usb: Fix on big-endian systems