From: Greg KH on
On Mon, May 17, 2010 at 08:30:23PM +0200, Arnd Bergmann wrote:
> On Monday 17 May 2010, Greg KH wrote:
> >
> > I'd prefer to do this for .36, not for .35. Arnd, I'll be glad to queue
> > these patches up to the tty development tree after .35-rc1 is out, so it
> > gets lots of testing in the linux-next tree, is that ok? If so, can you
> > resend them to me at that time?
>
> Ok, I'll make sure it still works with .35-rc1 when it's out and add
> Alan's ACK, then send a you a pull request. Did you already merge the
> series from Alan that this is based on, or do you want those patches
> to wait as well? They are in my git tree, so they will be included
> in my pull request if they are not in -rc1.

No, I do not have his patches anywhere, as I didn't expect that they
were being sent to me to apply :)

> Also, it would be nice if you could merge the first patch of my
> series, which should be completely harmless (it just renames
> function calls) but having it upstream means that we can
> keep the remaining patches that are required for BKL-less
> kernels a lot smaller.

Can you resend this patch to me so that I can include it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Arnd Bergmann on
On Tuesday 18 May 2010, Greg KH wrote:
> On Mon, May 17, 2010 at 08:30:23PM +0200, Arnd Bergmann wrote:
> > Ok, I'll make sure it still works with .35-rc1 when it's out and add
> > Alan's ACK, then send a you a pull request. Did you already merge the
> > series from Alan that this is based on, or do you want those patches
> > to wait as well? They are in my git tree, so they will be included
> > in my pull request if they are not in -rc1.
>
> No, I do not have his patches anywhere, as I didn't expect that they
> were being sent to me to apply :)
>
> > Also, it would be nice if you could merge the first patch of my
> > series, which should be completely harmless (it just renames
> > function calls) but having it upstream means that we can
> > keep the remaining patches that are required for BKL-less
> > kernels a lot smaller.
>
> Can you resend this patch to me so that I can include it?

I think we should only merge this patch if you also want to
take the patches from Alan mentioned above, otherwise it would
cause more trouble to rebase everything than we can gain from
merging it now.

If this makes sense to you, please pull

git://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git tty-for-2.6.35

This contains all of Alan's patches, plus the first one of my
series on top of that.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on
On Tue, May 18, 2010 at 11:52:01PM +0200, Arnd Bergmann wrote:
> >
> > Can you resend this patch to me so that I can include it?
>
> I think we should only merge this patch if you also want to
> take the patches from Alan mentioned above, otherwise it would
> cause more trouble to rebase everything than we can gain from
> merging it now.

Then I'll just wait, is that ok?

> If this makes sense to you, please pull
>
> git://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git tty-for-2.6.35
>
> This contains all of Alan's patches, plus the first one of my
> series on top of that.

I'll wait for you all to redo this and resend it to me for the .36
kernel.

Oh, and I really don't like to have a git pull, can you just email me
the patches?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Arnd Bergmann on
On Wednesday 19 May 2010, Greg KH wrote:
> On Tue, May 18, 2010 at 11:52:01PM +0200, Arnd Bergmann wrote:
> > >
> > > Can you resend this patch to me so that I can include it?
> >
> > I think we should only merge this patch if you also want to
> > take the patches from Alan mentioned above, otherwise it would
> > cause more trouble to rebase everything than we can gain from
> > merging it now.
>
> Then I'll just wait, is that ok?

ok

> > If this makes sense to you, please pull
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git tty-for-2.6.35
> >
> > This contains all of Alan's patches, plus the first one of my
> > series on top of that.
>
> I'll wait for you all to redo this and resend it to me for the .36
> kernel.
>
> Oh, and I really don't like to have a git pull, can you just email me
> the patches?

Yes, of course. That also answers the question whether to rebase or to
merge with -rc1.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Tony Luck on
On Mon, May 17, 2010 at 6:41 AM, Alan Cox <alan(a)lxorguk.ukuu.org.uk> wrote:
> At this point I think the only way to make further progress is to
> actually push this stuff into the kernel on top of the BKL removal
> patches for the drivers and see what happens. Something will no doubt
> break but we can try and nail them in time or if not revert the series
> and try again next kernel.

These changes showed up in linux-next (tag: next-20100617) ... and I'm seeing
a few WARN_ON messages on ia64 while booting:

WARNING: at include/linux/tty.h:589 tty_open+0x160/0xc60()
WARNING: at include/linux/tty.h:589 tty_open+0x9d0/0xc60()
WARNING: at include/linux/tty.h:589 tty_release+0x90/0xbc0()
WARNING: at include/linux/tty.h:589 tty_release+0x630/0xbc0()
WARNING: at include/linux/tty.h:589 tty_release+0x90/0xbc0()
WARNING: at include/linux/tty.h:589 tty_release+0x630/0xbc0()
WARNING: at include/linux/tty.h:589 tty_release+0x90/0xbc0()
WARNING: at include/linux/tty.h:589 tty_release+0x630/0xbc0()

Stack trace for the first of these looks like:
Call Trace:
[<a0000001000159d0>] show_stack+0x50/0xa0
[<a00000010090f250>] dump_stack+0x30/0x50
[<a00000010008e2c0>] warn_slowpath_common+0xc0/0x120
[<a00000010008e360>] warn_slowpath_null+0x40/0x60
[<a00000010053ebe0>] tty_open+0x160/0xc60
[<a0000001001af9b0>] chrdev_open+0x310/0x360
[<a0000001001a58b0>] __dentry_open+0x350/0x680
[<a0000001001a5d80>] nameidata_to_filp+0x80/0xc0
[<a0000001001bfee0>] finish_open+0x160/0x380
[<a0000001001c0cc0>] do_last+0xbc0/0xce0
[<a0000001001c5270>] do_filp_open+0x2f0/0xb40
[<a0000001001a5290>] do_sys_open+0x90/0x200
[<a0000001001a54d0>] sys_open+0x50/0x80
[<a000000100b907e0>] kernel_init+0x340/0x420
[<a000000100013c10>] kernel_thread_helper+0x30/0x60
[<a00000010000a0c0>] start_kernel_thread+0x20/0x40

Does anyone see anything similar on other architectures? Or is ia64 doing
something "special" here?

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/