LOCALVERSION_AUTO considered harmful
in [Kernel]
|
Prev: Lockup inside of stop_machine() during modprobe aes (was Re: Another AR5008 hang)
Next: Irish 2010 Grant Winner
From: Pavel Machek on 11 Apr 2010 12:50 LOCALVERSION_AUTO has nasty interaction with modules, warn about it. Signed-off-by: Pavel Machek <pavel(a)ucw.cz> diff --git a/init/Kconfig b/init/Kconfig index eb77e8c..5d33072 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -88,7 +88,6 @@ config LOCALVERSION config LOCALVERSION_AUTO bool "Automatically append version information to the version string" - default y help This will try to automatically determine if the current tree is a release tree by looking for git tags that belong to the current @@ -99,6 +98,11 @@ config LOCALVERSION_AUTO appended after any matching localversion* files, and after the value set in CONFIG_LOCALVERSION. + Unfortunately, such finegrained versioning will mean that you will + not be able to use modules for development; even "make modules" + will change module versions, making recompiled modules impossible + to insert into old kernel. + (The actual string used here is the first eight characters produced by running the command: -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Alexey Dobriyan on 11 Apr 2010 14:00 On Sun, Apr 11, 2010 at 06:47:01PM +0200, Pavel Machek wrote: > @@ -99,6 +98,11 @@ config LOCALVERSION_AUTO > appended after any matching localversion* files, and after the value > set in CONFIG_LOCALVERSION. > > + Unfortunately, such finegrained versioning will mean that you will > + not be able to use modules for development; even "make modules" > + will change module versions, making recompiled modules impossible > + to insert into old kernel. That's conditional BS. Turn off CONFIG_MODVERSIONS already. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Geert Uytterhoeven on 11 Apr 2010 15:00 On Mon, Apr 12, 2010 at 20:51, Alexey Dobriyan <adobriyan(a)gmail.com> wrote: > On Sun, Apr 11, 2010 at 06:47:01PM +0200, Pavel Machek wrote: >> @@ -99,6 +98,11 @@ config LOCALVERSION_AUTO >> appended after any matching localversion* files, and after the value >> set in CONFIG_LOCALVERSION. >> >> + Unfortunately, such finegrained versioning will mean that you will >> + not be able to use modules for development; even "make modules" >> + will change module versions, making recompiled modules impossible >> + to insert into old kernel. > > That's conditional BS. > Turn off CONFIG_MODVERSIONS already. Yeah, I disabled it ages ago. Even then (before git, probably even before bitkeeper) I had hard times inserting modules... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pavel Machek on 11 Apr 2010 16:20 On Sun 2010-04-11 20:58:58, Geert Uytterhoeven wrote: > On Mon, Apr 12, 2010 at 20:51, Alexey Dobriyan <adobriyan(a)gmail.com> wrote: > > On Sun, Apr 11, 2010 at 06:47:01PM +0200, Pavel Machek wrote: > >> @@ -99,6 +98,11 @@ config LOCALVERSION_AUTO > >> � � � � appended after any matching localversion* files, and after the value > >> � � � � set in CONFIG_LOCALVERSION. > >> > >> + � � � Unfortunately, such finegrained versioning will mean that you will > >> + � � � not be able to use modules for development; even "make modules" > >> + � � � will change module versions, making recompiled modules impossible > >> + � � � to insert into old kernel. > > > > That's conditional BS. > > Turn off CONFIG_MODVERSIONS already. > > Yeah, I disabled it ages ago. Even then (before git, probably even > before bitkeeper) > I had hard times inserting modules... I _had_ it off # CONFIG_MODVERSIONS is not set It seems some checking survives CONFIG_MODVERSIONS unset and that checking is strict enough to refuse module load after one "make modules" with LOCALVERSION_AUTO on... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Thomas Gleixner on 11 Apr 2010 18:30 On Sun, 11 Apr 2010, Pavel Machek wrote: > On Sun 2010-04-11 20:58:58, Geert Uytterhoeven wrote: > > On Mon, Apr 12, 2010 at 20:51, Alexey Dobriyan <adobriyan(a)gmail.com> wrote: > > > On Sun, Apr 11, 2010 at 06:47:01PM +0200, Pavel Machek wrote: > > >> @@ -99,6 +98,11 @@ config LOCALVERSION_AUTO > > >> � � � � appended after any matching localversion* files, and after the value > > >> � � � � set in CONFIG_LOCALVERSION. > > >> > > >> + � � � Unfortunately, such finegrained versioning will mean that you will > > >> + � � � not be able to use modules for development; even "make modules" > > >> + � � � will change module versions, making recompiled modules impossible > > >> + � � � to insert into old kernel. > > > > > > That's conditional BS. > > > Turn off CONFIG_MODVERSIONS already. > > > > Yeah, I disabled it ages ago. Even then (before git, probably even > > before bitkeeper) > > I had hard times inserting modules... > > I _had_ it off > > # CONFIG_MODVERSIONS is not set > > It seems some checking survives CONFIG_MODVERSIONS unset and that > checking is strict enough to refuse module load after one "make > modules" with LOCALVERSION_AUTO on... So instead of fixing the CONFIG_MODVERSIONS=n case you go the easy way of killing LOCALVERSION_AUTO ? Brilliant. Thanks, tglx
|
Next
|
Last
Pages: 1 2 3 Prev: Lockup inside of stop_machine() during modprobe aes (was Re: Another AR5008 hang) Next: Irish 2010 Grant Winner |