From: Greg KH on
On Wed, Jun 02, 2010 at 01:08:39PM -0700, Joe Perches wrote:
> On Wed, 2010-06-02 at 11:53 -0700, Greg KH wrote:
> > The TODO file in this directory clearly states who to copy on patches to
> > these files.
>
> Does anyone look at those? ;)

Yes, they should.

Heck, get_maintainer.pl would have given you the correct people to cc:
as well, why not use that?

> Signed-off-by: Joe Perches <joe(a)perches.com>
> ---
> MAINTAINERS | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2652ebc..e25e15a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5436,6 +5436,14 @@ L: devel(a)driverdev.osuosl.org
> S: Maintained
> F: drivers/staging/
>
> +STAGING B.A.T.M.A.N.
> +M: Marek Lindner <lindner_marek(a)yahoo.de>
> +M: Simon Wunderlich <siwu(a)hrz.tu-chemnitz.de>
> +M: Andrew Lunn <andrew(a)lunn.ch>
> +L: b.a.t.m.a.n(a)lists.open-mesh.net
> +S: Maintained (one day soon)
> +F: drivers/staging/batman-adv/

Care to at least cc: the people who you are adding to the file?

To not do so is a bit rude, don't you think so?

I'm not going to take this, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Joe Perches on
On Wed, 2010-06-02 at 13:19 -0700, Randy Dunlap wrote:
> On Wed, 2 Jun 2010 13:17:17 -0700 Greg KH wrote:
> > On Wed, Jun 02, 2010 at 01:08:39PM -0700, Joe Perches wrote:
> > > On Wed, 2010-06-02 at 11:53 -0700, Greg KH wrote:
> > > > The TODO file in this directory clearly states who to copy on patches to
> > > > these files.
> > > Does anyone look at those? ;)
> > Yes, they should.
> > Heck, get_maintainer.pl would have given you the correct people to cc:
> > as well, why not use that?

I know that script.
In fact, I did use it with my preferred options.

> > > Signed-off-by: Joe Perches <joe(a)perches.com>
> > > ---
> > > MAINTAINERS | 8 ++++++++
> > > 1 files changed, 8 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 2652ebc..e25e15a 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -5436,6 +5436,14 @@ L: devel(a)driverdev.osuosl.org
> > > S: Maintained
> > > F: drivers/staging/
> > >
> > > +STAGING B.A.T.M.A.N.
> > > +M: Marek Lindner <lindner_marek(a)yahoo.de>
> > > +M: Simon Wunderlich <siwu(a)hrz.tu-chemnitz.de>
> > > +M: Andrew Lunn <andrew(a)lunn.ch>
> > > +L: b.a.t.m.a.n(a)lists.open-mesh.net
> > > +S: Maintained (one day soon)
> > > +F: drivers/staging/batman-adv/
> >
> > Care to at least cc: the people who you are adding to the file?
> > To not do so is a bit rude, don't you think so?

twas, oversight. Apologies to them.

They're already described in a TODO file as the people to cc,
so I rather doubt they'll mind.

> > I'm not going to take this, sorry.

You're just being you.
Perhaps Andrew will take it.

cheers, Joe


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Randy Dunlap on
On Wed, 2 Jun 2010 13:17:17 -0700 Greg KH wrote:

> On Wed, Jun 02, 2010 at 01:08:39PM -0700, Joe Perches wrote:
> > On Wed, 2010-06-02 at 11:53 -0700, Greg KH wrote:
> > > The TODO file in this directory clearly states who to copy on patches to
> > > these files.
> >
> > Does anyone look at those? ;)
>
> Yes, they should.
>
> Heck, get_maintainer.pl would have given you the correct people to cc:
> as well, why not use that?
>
> > Signed-off-by: Joe Perches <joe(a)perches.com>
> > ---
> > MAINTAINERS | 8 ++++++++
> > 1 files changed, 8 insertions(+), 0 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 2652ebc..e25e15a 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -5436,6 +5436,14 @@ L: devel(a)driverdev.osuosl.org
> > S: Maintained
> > F: drivers/staging/
> >
> > +STAGING B.A.T.M.A.N.
> > +M: Marek Lindner <lindner_marek(a)yahoo.de>
> > +M: Simon Wunderlich <siwu(a)hrz.tu-chemnitz.de>
> > +M: Andrew Lunn <andrew(a)lunn.ch>
> > +L: b.a.t.m.a.n(a)lists.open-mesh.net
> > +S: Maintained (one day soon)
> > +F: drivers/staging/batman-adv/
>
> Care to at least cc: the people who you are adding to the file?
>
> To not do so is a bit rude, don't you think so?
>
> I'm not going to take this, sorry.


Sure he should have cc-ed them, but it's still a valid patch and should
be applied.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/