Prev: Today's Linus.git hangs during boot: can't find the floppy controller
Next: regulator: tps6507x - add missing platform_set_drvdata in tps6507x_pmic_probe
From: Axel Lin on 9 Aug 2010 02:50
The i2c_client received in probe() should not be kfree()'d.

Signed-off-by: Axel Lin <axel.lin(a)gmail.com>
---
drivers/mfd/max8998.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c
index 0d68de2..73e6f5c 100644
--- a/drivers/mfd/max8998.c
+++ b/drivers/mfd/max8998.c
@@ -89,10 +89,8 @@ static int max8998_i2c_probe(struct i2c_client *i2c,
int ret = 0;

max8998 = kzalloc(sizeof(struct max8998_dev), GFP_KERNEL);
- if (max8998 == NULL) {
- kfree(i2c);
+ if (max8998 == NULL)
return -ENOMEM;
- }

i2c_set_clientdata(i2c, max8998);
max8998->dev = &i2c->dev;
--
1.5.4.3



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: Today's Linus.git hangs during boot: can't find the floppy controller
Next: regulator: tps6507x - add missing platform_set_drvdata in tps6507x_pmic_probe