From: Markus Trippelsdorf on
On Sun, Aug 08, 2010 at 01:17:53PM -0700, walt wrote:
> This commit produces the error:
>
> commit 6ee0578b4daaea01c96b172c6aacca43fd9807a6
> Author: Suresh Siddha <suresh.b.siddha(a)intel.com>
> Date: Fri Jul 30 14:57:37 2010 -0700
>
> workqueue: mark init_workqueues() as early_initcall()
>
> Mark init_workqueues() as early_initcall() and thus it will be initialized
> before smp bringup. init_workqueues() registers for the hotcpu notifier
> and thus it should cope with the processors that are brought online after
> the workqueues are initialized.
>
> x86 smp bringup code uses workqueues and uses a workaround for the
> cold boot process (as the workqueues are initialized post smp_init()).
> Marking init_workqueues() as early_initcall() will pave the way for
> cleaning up this code.
>
> Signed-off-by: Suresh Siddha <suresh.b.siddha(a)intel.com>
> Signed-off-by: Tejun Heo <tj(a)kernel.org>
> Cc: Oleg Nesterov <oleg(a)redhat.com>
> Cc: Andrew Morton <akpm(a)linux-foundation.org>
>
>
> Just after the error message about the floppy controller not found, the
> machine hangs for two minutes and then this message:
>
> task swapper:1 blocked for greater than 120 seconds, followed by a stack
> trace, and again every two minutes AFAICT.
>
> I'm not including all the gory messages and stack traces because I'm
> hoping you'll know what the problem is without them. (Fingers crossed.)
>
> BTW, I see this problem only on my dual-core machine, not the older single
> single processor machine, as I would expect from reading the commit message.
> (Both machine have properly functioning floppy drives.)

(Added Tejun to CC)

I see a similar problem here. The kernel will boot, but the system will
not initialize (no X11).
After reverting the commit, the system starts normally and the only
workqueue problem left is drm related:

% dmesg | grep ERROR
[drm:drm_kms_helper_poll_enable] *ERROR* delayed enqueue failed 1
[drm:output_poll_execute] *ERROR* delayed enqueue failed 1
[drm:output_poll_execute] *ERROR* delayed enqueue failed 1
[drm:output_poll_execute] *ERROR* delayed enqueue failed 1
[drm:output_poll_execute] *ERROR* delayed enqueue failed 1
[drm:output_poll_execute] *ERROR* delayed enqueue failed 1
[drm:output_poll_execute] *ERROR* delayed enqueue failed 1
[drm:output_poll_execute] *ERROR* delayed enqueue failed 1
....


--
�A man who doesn't know he is in prison can never escape.�
William S. Burroughs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Heiko Carstens on
On Mon, Aug 09, 2010 at 08:37:42AM +0200, Markus Trippelsdorf wrote:
> On Sun, Aug 08, 2010 at 01:17:53PM -0700, walt wrote:
> > This commit produces the error:
> >
> > commit 6ee0578b4daaea01c96b172c6aacca43fd9807a6
> > Author: Suresh Siddha <suresh.b.siddha(a)intel.com>
> > Date: Fri Jul 30 14:57:37 2010 -0700
> >
> > workqueue: mark init_workqueues() as early_initcall()
> >
> > Mark init_workqueues() as early_initcall() and thus it will be initialized
> > before smp bringup. init_workqueues() registers for the hotcpu notifier
> > and thus it should cope with the processors that are brought online after
> > the workqueues are initialized.
> >
> > x86 smp bringup code uses workqueues and uses a workaround for the
> > cold boot process (as the workqueues are initialized post smp_init()).
> > Marking init_workqueues() as early_initcall() will pave the way for
> > cleaning up this code.
> >
> > Signed-off-by: Suresh Siddha <suresh.b.siddha(a)intel.com>
> > Signed-off-by: Tejun Heo <tj(a)kernel.org>
> > Cc: Oleg Nesterov <oleg(a)redhat.com>
> > Cc: Andrew Morton <akpm(a)linux-foundation.org>
> >
> >
> > Just after the error message about the floppy controller not found, the
> > machine hangs for two minutes and then this message:
> >
> > task swapper:1 blocked for greater than 120 seconds, followed by a stack
> > trace, and again every two minutes AFAICT.
> >
> > I'm not including all the gory messages and stack traces because I'm
> > hoping you'll know what the problem is without them. (Fingers crossed.)
> >
> > BTW, I see this problem only on my dual-core machine, not the older single
> > single processor machine, as I would expect from reading the commit message.
> > (Both machine have properly functioning floppy drives.)
>
> (Added Tejun to CC)
>
> I see a similar problem here. The kernel will boot, but the system will
> not initialize (no X11).
> After reverting the commit, the system starts normally and the only
> workqueue problem left is drm related:

I would guess that both of you have CONFIG_HOTPLUG_CPU disabled and enabling
that config option will make the problem disappear.
From the problem description and the patch it looks like it got screwed up
the same way I did two years ago.
See commits a802dd0eb5fc97a50cf1abb1f788a8f6cc5db635 and
4403b406d4369a275d483ece6ddee0088cc0d592.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Heiko Carstens on
On Mon, Aug 09, 2010 at 10:30:53AM +0200, Heiko Carstens wrote:
> On Mon, Aug 09, 2010 at 08:37:42AM +0200, Markus Trippelsdorf wrote:
> > On Sun, Aug 08, 2010 at 01:17:53PM -0700, walt wrote:
> > > This commit produces the error:
> > >
> > > commit 6ee0578b4daaea01c96b172c6aacca43fd9807a6
> > > Author: Suresh Siddha <suresh.b.siddha(a)intel.com>
> > > Date: Fri Jul 30 14:57:37 2010 -0700
> > >
> > > workqueue: mark init_workqueues() as early_initcall()
> > >
> > > Mark init_workqueues() as early_initcall() and thus it will be initialized
> > > before smp bringup. init_workqueues() registers for the hotcpu notifier
> > > and thus it should cope with the processors that are brought online after
> > > the workqueues are initialized.
> > >
> > > x86 smp bringup code uses workqueues and uses a workaround for the
> > > cold boot process (as the workqueues are initialized post smp_init()).
> > > Marking init_workqueues() as early_initcall() will pave the way for
> > > cleaning up this code.
> > >
> > > Signed-off-by: Suresh Siddha <suresh.b.siddha(a)intel.com>
> > > Signed-off-by: Tejun Heo <tj(a)kernel.org>
> > > Cc: Oleg Nesterov <oleg(a)redhat.com>
> > > Cc: Andrew Morton <akpm(a)linux-foundation.org>
> > >
> > >
> > > Just after the error message about the floppy controller not found, the
> > > machine hangs for two minutes and then this message:
> > >
> > > task swapper:1 blocked for greater than 120 seconds, followed by a stack
> > > trace, and again every two minutes AFAICT.
> > >
> > > I'm not including all the gory messages and stack traces because I'm
> > > hoping you'll know what the problem is without them. (Fingers crossed.)
> > >
> > > BTW, I see this problem only on my dual-core machine, not the older single
> > > single processor machine, as I would expect from reading the commit message.
> > > (Both machine have properly functioning floppy drives.)
> >
> > (Added Tejun to CC)
> >
> > I see a similar problem here. The kernel will boot, but the system will
> > not initialize (no X11).
> > After reverting the commit, the system starts normally and the only
> > workqueue problem left is drm related:
>
> I would guess that both of you have CONFIG_HOTPLUG_CPU disabled and enabling
> that config option will make the problem disappear.
> From the problem description and the patch it looks like it got screwed up
> the same way I did two years ago.
> See commits a802dd0eb5fc97a50cf1abb1f788a8f6cc5db635 and
> 4403b406d4369a275d483ece6ddee0088cc0d592.

Add Suresh to cc list.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Tejun Heo on
Hello,

On 08/09/2010 10:34 AM, Heiko Carstens wrote:
>>> I see a similar problem here. The kernel will boot, but the system will
>>> not initialize (no X11).
>>> After reverting the commit, the system starts normally and the only
>>> workqueue problem left is drm related:
>>
>> I would guess that both of you have CONFIG_HOTPLUG_CPU disabled and enabling
>> that config option will make the problem disappear.
>> From the problem description and the patch it looks like it got screwed up
>> the same way I did two years ago.
>> See commits a802dd0eb5fc97a50cf1abb1f788a8f6cc5db635 and
>> 4403b406d4369a275d483ece6ddee0088cc0d592.

Heh, that's almost hilarious. I'll see if this can be fixed
differently this time.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/