Prev: [PATCH] Remove 9 second reboot delay on Lenovo T400/T500
Next: Version 2: Provide /sys/../ec with read/write access and some cleanups
From: Thomas Renninger on 16 Jul 2010 07:20 Formerly these have been exposed through /proc/.. Better register them where all IO ports should get registered and scream loud if someone else claims to use them. EC data and command port typically should show up like this then: .... 0060-0060 : keyboard 0062-0062 : EC data 0064-0064 : keyboard 0066-0066 : EC command 0070-0071 : rtc0 .... Signed-off-by: Thomas Renninger <trenn(a)suse.de> CC: Alexey Starikovskiy <astarikovskiy(a)suse.de> CC: Len Brown <lenb(a)kernel.org> CC: linux-kernel(a)vger.kernel.org CC: linux-acpi(a)vger.kernel.org CC: Bjorn Helgaas <bjorn.helgaas(a)hp.com> CC: platform-driver-x86(a)vger.kernel.org --- drivers/acpi/ec.c | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c index 4b6759f..f95fa9f 100644 --- a/drivers/acpi/ec.c +++ b/drivers/acpi/ec.c @@ -927,10 +927,18 @@ ec_parse_io_ports(struct acpi_resource *resource, void *context) * the second address region returned is the status/command * port. */ - if (ec->data_addr == 0) + if (ec->data_addr == 0) { ec->data_addr = resource->data.io.minimum; - else if (ec->command_addr == 0) + WARN(!request_region(ec->data_addr, 1, "EC data"), + "Could not request EC data io port %lu", + ec->data_addr); + } + else if (ec->command_addr == 0) { ec->command_addr = resource->data.io.minimum; + WARN(!request_region(ec->command_addr, 1, "EC command"), + "Could not request EC command io port %lu", + ec->command_addr); + } else return AE_CTRL_TERMINATE; -- 1.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |