[PATCH v3] ath5k: disable ASPM
in [Kernel]
|
From: Matthew Garrett on 26 Jul 2010 19:00 On Mon, Jul 26, 2010 at 03:43:04PM -0700, Luis R. Rodriguez wrote: > I see.. thanks Mathew... in that case since L1 works on all devices we > could just force enable L1 for all PCIE devices. What do you think? Works for me. -- Matthew Garrett | mjg59(a)srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Maxim Levitsky on 27 Jul 2010 05:40 On Mon, 2010-07-26 at 23:50 +0100, Matthew Garrett wrote: > On Mon, Jul 26, 2010 at 03:43:04PM -0700, Luis R. Rodriguez wrote: > > > I see.. thanks Mathew... in that case since L1 works on all devices we > > could just force enable L1 for all PCIE devices. What do you think? > > Works for me. > On the second thought, there is no 'pci_enable_link_state' :-) I afraid that if I add it, I might not do that right for all cases, thus do more harm that good... Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Luis R. Rodriguez on 27 Jul 2010 12:00 On Tue, Jul 27, 2010 at 2:35 AM, Maxim Levitsky <maximlevitsky(a)gmail.com> wrote: > On Mon, 2010-07-26 at 23:50 +0100, Matthew Garrett wrote: >> On Mon, Jul 26, 2010 at 03:43:04PM -0700, Luis R. Rodriguez wrote: >> >> > I see.. thanks Mathew... in that case since L1 works on all devices we >> > could just force enable L1 for all PCIE devices. What do you think? >> >> Works for me. >> > > On the second thought, there is no 'pci_enable_link_state' :-) > I afraid that if I add it, I might not do that right for all cases, thus > do more harm that good... I'm sorry, can you elaborate? Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Maxim Levitsky on 28 Jul 2010 19:50 On Tue, 2010-07-27 at 08:57 -0700, Luis R. Rodriguez wrote: > On Tue, Jul 27, 2010 at 2:35 AM, Maxim Levitsky <maximlevitsky(a)gmail.com> wrote: > > On Mon, 2010-07-26 at 23:50 +0100, Matthew Garrett wrote: > >> On Mon, Jul 26, 2010 at 03:43:04PM -0700, Luis R. Rodriguez wrote: > >> > >> > I see.. thanks Mathew... in that case since L1 works on all devices we > >> > could just force enable L1 for all PCIE devices. What do you think? > >> > >> Works for me. > >> > > > > On the second thought, there is no 'pci_enable_link_state' :-) > > I afraid that if I add it, I might not do that right for all cases, thus > > do more harm that good... > > I'm sorry, can you elaborate? I mean ASPM code doesn't have a function to undo effects of the blacklist (due to pre 1.1 pcie device). Its not that simple to write such function. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Luis R. Rodriguez on 28 Jul 2010 20:10
On Wed, Jul 28, 2010 at 4:48 PM, Maxim Levitsky <maximlevitsky(a)gmail.com> wrote: > On Tue, 2010-07-27 at 08:57 -0700, Luis R. Rodriguez wrote: >> On Tue, Jul 27, 2010 at 2:35 AM, Maxim Levitsky <maximlevitsky(a)gmail.com> wrote: >> > On Mon, 2010-07-26 at 23:50 +0100, Matthew Garrett wrote: >> >> On Mon, Jul 26, 2010 at 03:43:04PM -0700, Luis R. Rodriguez wrote: >> >> >> >> > I see.. thanks Mathew... in that case since L1 works on all devices we >> >> > could just force enable L1 for all PCIE devices. What do you think? >> >> >> >> Works for me. >> >> >> > >> > On the second thought, there is no 'pci_enable_link_state' :-) >> > I afraid that if I add it, I might not do that right for all cases, thus >> > do more harm that good... >> >> I'm sorry, can you elaborate? > > I mean ASPM code doesn't have a function to undo effects of the > blacklist (due to pre 1.1 pcie device). > > Its not that simple to write such function. Ah good catch... pcie_aspm_sanity_check() will actually be used to adjust the device link capability... So even if we do try to insist it wouldn't work. I'm happy if we deal with this separately, its a reasonable compromise to fix issues with existing devices out there. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |