From: Frans Pop on
On Friday 16 April 2010, Frans Pop wrote:
> With 2.6.33 and earlier the sound would always come from the external
> speakers connected to the docking station. But with 2.6.34-rc4 I get
> sound still coming from the laptop's internal speakers, which is not
> correct.

Forgot to mention that sound does get transferred to the external speakers
with .34 if I do an extra undock and redock after the resume.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Frans Pop on
On Friday 16 April 2010, Frans Pop wrote:
> Scenario:
> - suspend laptop while *un*docked, i.e. with laptop speakers in use
> - dock laptop
> - resume
>
> With 2.6.33 and earlier the sound would always come from the external
> speakers connected to the docking station. But with 2.6.34-rc4 I get
> sound still coming from the laptop's internal speakers, which is not
> correct.

The problem is slightly different than I thought. Turns out *both* the
internal (laptop) and external (docking station) speakers are active after
the resume. So the problem is that the internal speakers are not switched off.

I have traced this to an ALSA merge: 524df55725217. Unfortunately I get
boot failures when I try to bisect down into that merge.

Here's the bisect log:
# bad: [0d0fb0f9c5fddef4a10242fe3337f00f528a3099] Linux 2.6.34-rc4
# good: [724e6d3fe8003c3f60bf404bf22e4e331327c596] Linux 2.6.33-rc8
git bisect start 'v2.6.34-rc4' 'v2.6.33-rc8'
# bad: [94468080220162f74dc6ce5c3e95e5fec8022902]
Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty-2.6
git bisect bad 94468080220162f74dc6ce5c3e95e5fec8022902
# bad: [524df55725217b13d5a232fb5badb5846418ea0e] Merge branch 'for-linus'
of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6
git bisect bad 524df55725217b13d5a232fb5badb5846418ea0e
# good: [0f4533979473a456a8adb3869365e12c7a99cf65]
Merge branches 'futexes-for-linus', 'irq-core-for-linus' and
'bkl-drivers-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
git bisect good 0f4533979473a456a8adb3869365e12c7a99cf65

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Takashi Iwai on
At Sat, 17 Apr 2010 11:06:22 +0200,
Frans Pop wrote:
>
> On Friday 16 April 2010, Frans Pop wrote:
> > Scenario:
> > - suspend laptop while *un*docked, i.e. with laptop speakers in use
> > - dock laptop
> > - resume
> >
> > With 2.6.33 and earlier the sound would always come from the external
> > speakers connected to the docking station. But with 2.6.34-rc4 I get
> > sound still coming from the laptop's internal speakers, which is not
> > correct.
>
> The problem is slightly different than I thought. Turns out *both* the
> internal (laptop) and external (docking station) speakers are active after
> the resume. So the problem is that the internal speakers are not switched off.
>
> I have traced this to an ALSA merge: 524df55725217. Unfortunately I get
> boot failures when I try to bisect down into that merge.
>
> Here's the bisect log:
> # bad: [0d0fb0f9c5fddef4a10242fe3337f00f528a3099] Linux 2.6.34-rc4
> # good: [724e6d3fe8003c3f60bf404bf22e4e331327c596] Linux 2.6.33-rc8
> git bisect start 'v2.6.34-rc4' 'v2.6.33-rc8'
> # bad: [94468080220162f74dc6ce5c3e95e5fec8022902]
> Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty-2.6
> git bisect bad 94468080220162f74dc6ce5c3e95e5fec8022902
> # bad: [524df55725217b13d5a232fb5badb5846418ea0e] Merge branch 'for-linus'
> of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6
> git bisect bad 524df55725217b13d5a232fb5badb5846418ea0e
> # good: [0f4533979473a456a8adb3869365e12c7a99cf65]
> Merge branches 'futexes-for-linus', 'irq-core-for-linus' and
> 'bkl-drivers-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
> git bisect good 0f4533979473a456a8adb3869365e12c7a99cf65

Could you give alsa-info.sh on your machine, preferably before/after
suspend on both working (2.6.33) and non-working kernels?

Also, you can try to copy sound/pci/hda/patch_analog.c from 2.6.33 to
2.6.34 to check whether it works. There shouldn't be many changes in
that file.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Frans Pop on
On Monday 19 April 2010, Takashi Iwai wrote:
> Could you give alsa-info.sh on your machine, preferably before/after
> suspend on both working (2.6.33) and non-working kernels?

See files in attached tarball. Contents are:
* system boot (docked)
=> alsa-info.txt_3[34]_docked
* undock
=> alsa-info.txt_3[34]_undocked
* suspend - dock (while suspended) - resume
=> alsa-info.txt_3[34]_after_resume_docked
* undock - redock (this disables the internal speakers)
=> alsa-info.txt_34_after_resume_redocked

> Also, you can try to copy sound/pci/hda/patch_analog.c from 2.6.33 to
> 2.6.34 to check whether it works. There shouldn't be many changes in
> that file.

That fixes the problem.

Thanks,
FJP

From: Takashi Iwai on
At Mon, 19 Apr 2010 13:38:14 +0200,
Frans Pop wrote:
>
> On Monday 19 April 2010, Takashi Iwai wrote:
> > Could you give alsa-info.sh on your machine, preferably before/after
> > suspend on both working (2.6.33) and non-working kernels?
>
> See files in attached tarball. Contents are:
> * system boot (docked)
> => alsa-info.txt_3[34]_docked
> * undock
> => alsa-info.txt_3[34]_undocked
> * suspend - dock (while suspended) - resume
> => alsa-info.txt_3[34]_after_resume_docked
> * undock - redock (this disables the internal speakers)
> => alsa-info.txt_34_after_resume_redocked
>
> > Also, you can try to copy sound/pci/hda/patch_analog.c from 2.6.33 to
> > 2.6.34 to check whether it works. There shouldn't be many changes in
> > that file.
>
> That fixes the problem.

Then my rough guess is

commit ea52bf260ecbb175339af3178c15788df21b7516
Author: Daniel T Chen <crimsun(a)ubuntu.com>
Date: Sun Dec 27 18:48:29 2009 -0500

ALSA: hda: Add powerdown for Analog Devices HDA codecs

Could you try to revert it?


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/