From: Joe Perches on
On Wed, 2010-04-21 at 02:49 +0200, Mikal Sande wrote:
> @@ -212,7 +212,9 @@ ssize_t bat_device_write(struct file *file, const char __user *buff,
> unsigned long flags;
>
> if (len < sizeof(struct icmp_packet)) {
> - bat_dbg(DBG_BATMAN, "batman-adv:Error - can't send packet from char device: invalid packet size\n");
> + bat_dbg(DBG_BATMAN, "batman-adv:" +
> + "Error - can't send packet from char device: " +
> + "invalid packet size\n");

C doesn't use + for string concatenation.
Please compile test your changes before submitting them.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Sven Eckelmann on
Mikal Sande wrote:
> >>From fc01d526b79f61248191493c7ac779def6b50281 Mon Sep 17 00:00:00 2001
>
> From: Mikal Sande <mikal.sande(a)gmail.com>
> Date: Wed, 21 Apr 2010 00:18:14 +0200
> Subject: [PATCH] Staging: batman-adv: fix checkpath.pl issues
> This is a patch to all the .c files in batman-adv that fixes the
> checkpatch.pl issues Signed-off-by: Mikal Sande <mikal.sande(a)gmail.com>

Your patch doesn't apply anymore. See
1270341625-28764-1-git-send-email-luisbg(a)ubuntu.com and follow ups [1].

Best regards,
Sven Eckelmann

[1] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2010-April/002476.html