Prev: USB: gadget: file_storage: serial parameter even if not test mode
Next: perf annotate segfaults when source code has goto label that looks like hex number
From: Alan Stern on 22 Jul 2010 10:30
On Thu, 22 Jul 2010, Michal Nazarewicz wrote:

> This patch removes code from usb_choose_configuration()
> responsible for ignoring the first USB device configuration if
> its first interface is RNDIS. Instead,
> usb_choose_configuration() chooses configuration with lowest
> bConfigurationValue. Linux' Ethernet gadget uses a lower
> bConfigurationValue for the second configuration which is
> a CDC configuration so this code should choose configuration
> that suits Linux better.

I don't like this idea. Choosing configs is a sensitive topic, since
it is highly visible to users. It should be changed minimally, if at
all.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Oliver Neukum on 23 Jul 2010 04:00
Am Donnerstag, 22. Juli 2010, 16:09:10 schrieb Michal Nazarewicz:
> This patch removes code from usb_choose_configuration()
> responsible for ignoring the first USB device configuration if
> its first interface is RNDIS. Instead,
> usb_choose_configuration() chooses configuration with lowest
> bConfigurationValue. Linux' Ethernet gadget uses a lower
> bConfigurationValue for the second configuration which is
> a CDC configuration so this code should choose configuration
> that suits Linux better.

But what if the other side is not a Linux gadget? We need this code
to not select RNDIS on those devices. I am afraid we can't do this?

Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: USB: gadget: file_storage: serial parameter even if not test mode
Next: perf annotate segfaults when source code has goto label that looks like hex number