Prev: [PATCHv3 00/14] kill unnecessary bdi wakeups + cleanups
Next: USB: core: Choose configuration with lowest bConfigurationValue
From: Alan Stern on 22 Jul 2010 10:20
On Thu, 22 Jul 2010, Michal Nazarewicz wrote:

> Moved the serial parameter handling code out of "#ifdef
> CONFIG_USB_FILE_STORAGE_TEST".
>
> This modifies Yann Cantin's commit "USB: Add a serial number
> parameter to g_file_storage" module as per Alan Stern's request.
>
> Signed-off-by: Michal Nazarewicz <m.nazarewicz(a)samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com>
> Cc: Alan Stern <stern(a)rowland.harvard.edu>
> Cc: Yann Cantin <yann.cantin(a)laposte.net>
> ---
> Alan Stern wrote:
> > I have only one objection to this [Yann Cantin's] patch: The new
> > parameter's name should be "serial", not "serial_parm".
>
> Alan Stern wrote:
> > The serial number parameter is important enough that it should be
> > available even on builds without CONFIG_USB_FILE_STORAGE_TEST.
>
> drivers/usb/gadget/file_storage.c | 20 +++++++++++---------
> 1 files changed, 11 insertions(+), 9 deletions(-)

Acked-by: Alan Stern <stern(a)rowland.harvard.edu>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCHv3 00/14] kill unnecessary bdi wakeups + cleanups
Next: USB: core: Choose configuration with lowest bConfigurationValue