From: Alan Stern on
On Sat, 19 Sep 2009, Johan Hovold wrote:

> Use ASYNCB_INITIALIZED to determine when to stop reading.
>
> Since 335f8514f200e63d689113d29cb7253a5c282967 port count can no longer
> be used to determine when to stop reading from the device as it can be
> zero when the first read callbacks are made (see tty_port_block_til_read
> where port count is temporarily decremented during serial_open).
>
> This fixes the regression where reads fail after connecting the device
> and opening the port more than once (reads usually succeed after the
> first open due to the device latency timer then being set to the default
> 16ms rather than 1ms).

This is a good change. It should be made in all the serial drivers,
not just ftdi_sio. How'd you like to submit patches for all the rest
of the drivers?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Johan Hovold on
On Sat, Sep 19, 2009 at 12:20:53PM -0400, Alan Stern wrote:
> On Sat, 19 Sep 2009, Johan Hovold wrote:
> > Use ASYNCB_INITIALIZED to determine when to stop reading.
> This is a good change. It should be made in all the serial drivers,
> not just ftdi_sio. How'd you like to submit patches for all the rest
> of the drivers?

Sure, I'll do that tomorrow.

/Johan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/