Whitespace Coding style fixes.
in [Kernel]
|
Prev: Cleancache [PATCH 0/7] (was Transcendent Memory): overview
Next: Frontswap [PATCH 0/4] (was Transcendent Memory): overview
From: James Morris on 23 Apr 2010 01:20 On Thu, 22 Apr 2010, Justin P. Mattock wrote: > side note: what/where is the git web interface So I can > see how you changed the patch(so I know the next). > I'm looking here: > http://git.kernel.org/?p=linux/kernel/git/jmorris/security-testing-2.6.git;a=summary > > is this correct? Yeah, there should be a 'next' link to click on somewhere to get the right branch. -- James Morris <jmorris(a)namei.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Justin P. Mattock on 23 Apr 2010 01:30 On 04/22/2010 10:17 PM, James Morris wrote: > On Thu, 22 Apr 2010, Justin P. Mattock wrote: > >> side note: what/where is the git web interface So I can >> see how you changed the patch(so I know the next). >> I'm looking here: >> http://git.kernel.org/?p=linux/kernel/git/jmorris/security-testing-2.6.git;a=summary >> >> is this correct? > > Yeah, there should be a 'next' link to click on somewhere to get the right > branch. > duh.. I didn't scroll all the way down the page.. I see it now. as for the subject line.. o.k... my mistake(I should of know to do so) thanks for fixing this for me. as for going through a doing this If I see more obvious fixes is it cool to just add you unto the CC or should I not even bother since git-blame gets funky?! Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Florian Mickler on 21 Apr 2010 09:00 On Wed, 21 Apr 2010 00:34:41 -0700 Joe Perches <joe(a)perches.com> wrote: > On Wed, 2010-04-21 at 00:09 -0700, Justin P. Mattock wrote: > > On 04/21/2010 12:03 AM, Alexey Dobriyan wrote: > > > You screw up git-blame. > > how does this patch screw it up? > > Alexey just doesn't like whitespace patches. > > Whitespace patches don't really "screw up" git blame. > > git blame displays the current version of a file > with line-by-line commits and the date each line > was last modified. > > So whitespace changes make it harder to find which patch > introduced the last logical change for a particular line. git blame -w -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Justin P. Mattock on 21 Apr 2010 09:30
On 04/21/2010 12:34 AM, Joe Perches wrote: > On Wed, 2010-04-21 at 00:09 -0700, Justin P. Mattock wrote: >> On 04/21/2010 12:03 AM, Alexey Dobriyan wrote: >>> You screw up git-blame. >> how does this patch screw it up? > > Alexey just doesn't like whitespace patches. > > Whitespace patches don't really "screw up" git blame. > > git blame displays the current version of a file > with line-by-line commits and the date each line > was last modified. > > So whitespace changes make it harder to find which patch > introduced the last logical change for a particular line. > > A more interactive git blame with history backtracking > might help keep Alexey happier but who knows for sure... > > ahh.. so after adding this patch, and committing it in my branch the doing git blame security/commoncap.c only shows something from James Morris instead of what my change had brought. Alright I can see why it screws things up.. I'll not (L)indent the whole tree then... Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |