From: Alexey Dobriyan on
Don't send this.
You screw up git-blame.

On Wed, Apr 21, 2010 at 10:02 AM, Justin P. Mattock
<justinmattock(a)gmail.com> wrote:
> Whitespace Coding style fixes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Justin P. Mattock on
On 04/21/2010 12:03 AM, Alexey Dobriyan wrote:
> Don't send this.
> You screw up git-blame.
>

I'm not sure how git-blame works.
how does this patch screw it up?

Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: James Morris on
On Wed, 21 Apr 2010, Justin P. Mattock wrote:

> Whitespace Coding style fixes.
>
> Signed-off-by: Justin P. Mattock <justinmattock(a)gmail.com>


Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next

with fixes to the Subject: line (needed a subsystem field and fixed
capitalization).

--
James Morris
<jmorris(a)namei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Joe Perches on
On Wed, 2010-04-21 at 00:09 -0700, Justin P. Mattock wrote:
> On 04/21/2010 12:03 AM, Alexey Dobriyan wrote:
> > You screw up git-blame.
> how does this patch screw it up?

Alexey just doesn't like whitespace patches.

Whitespace patches don't really "screw up" git blame.

git blame displays the current version of a file
with line-by-line commits and the date each line
was last modified.

So whitespace changes make it harder to find which patch
introduced the last logical change for a particular line.

A more interactive git blame with history backtracking
might help keep Alexey happier but who knows for sure...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Justin P. Mattock on
On 04/22/2010 05:17 PM, James Morris wrote:
> On Wed, 21 Apr 2010, Justin P. Mattock wrote:
>
>> Whitespace Coding style fixes.
>>
>> Signed-off-by: Justin P. Mattock<justinmattock(a)gmail.com>
>
>
> Applied to
> git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next
>
> with fixes to the Subject: line (needed a subsystem field and fixed
> capitalization).
>

Cool thank you vary much..

side note: what/where is the git web interface So I can
see how you changed the patch(so I know the next).
I'm looking here:
http://git.kernel.org/?p=linux/kernel/git/jmorris/security-testing-2.6.git;a=summary

is this correct?

Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/