Prev: Setting /proc/irq/[n]/smp_affinity failure on 8 cpu systems
Next: [ANNOUNCE] lsscsi-0.23 released
From: Wu Fengguang on 2 Dec 2009 21:00
On Thu, Dec 03, 2009 at 06:52:43AM +0800, Andi Kleen wrote:
> On Wed, Dec 02, 2009 at 02:48:03PM -0800, Paul Menage wrote:
> > On Tue, Dec 1, 2009 at 7:12 PM, Wu Fengguang <fengguang.wu(a)intel.com> wrote:
> > > --- linux-mm.orig/include/linux/cgroup.h        2009-11-02 10:18:41.000000000 +0800
> > > +++ linux-mm/include/linux/cgroup.h     2009-11-02 10:26:22.000000000 +0800
> > > @@ -581,6 +581,9 @@ static inline int cgroupstats_build(stru
> > >        return -EINVAL;
> > >  }
> > >
> > > +struct cgroup_subsys_state;
> > > +static inline void css_put(struct cgroup_subsys_state *css) {}
> > > +
> > >  #endif /* !CONFIG_CGROUPS */
> >
> > This doesn't sound like the right thing to do - if !CONFIG_CGROUPS,
> > then the code shouldn't be able to see a css structure to pass to this
> > function.
>
> I agree. The high level code should be ifdefed.

Right. Following your suggestion to ifdef the memcg user
hwpoison_filter_task(), this patch can be dropped.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: Setting /proc/irq/[n]/smp_affinity failure on 8 cpu systems
Next: [ANNOUNCE] lsscsi-0.23 released