Prev: writeback: tracing and wbc->nr_to_write fixes
Next: writeback: initial tracing support
From: Sridhar Samudrala on 21 May 2010 11:10
On 5/20/2010 3:22 PM, Paul Menage wrote:
> On Tue, May 18, 2010 at 5:04 PM, Sridhar Samudrala
> <samudrala.sridhar(a)gmail.com> wrote:
>
>> Add a new kernel API to attach a task to current task's cgroup
>> in all the active hierarchies.
>>
>> Signed-off-by: Sridhar Samudrala<sri(a)us.ibm.com>
>>
> Reviewed-by: Paul Menage<menage(a)google.com>
>
> It would be more efficient to just attach directly to current->cgroups
> rather than potentially creating/destroying one css_set for each
> hierarchy until we've completely converged on current->cgroups - but
> that would require a bunch of refactoring of the guts of
> cgroup_attach_task() to ensure that the right can_attach()/attach()
> callbacks are made. That doesn't really seem worthwhile right now for
> the initial use, that I imagine isn't going to be
> performance-sensitive.
>
Yes. In our use-case, this will be called only once per guest interface
when the guest comes up.
Hope you or someone more familiar with cgroups subsystem can optimize
this function later.

Thanks
Sridhar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Li Zefan on 30 May 2010 21:10
04:24, Tejun Heo wrote:
> From: Sridhar Samudrala <samudrala.sridhar(a)gmail.com>
>
> Add a new kernel API to attach a task to current task's cgroup
> in all the active hierarchies.
>
> Signed-off-by: Sridhar Samudrala <sri(a)us.ibm.com>

Acked-by: Li Zefan <lizf(a)cn.fujitsu.com>

btw: you lost the reviewed-by tag given by Paul Menage.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Tejun Heo on 31 May 2010 03:10
On 05/31/2010 03:07 AM, Li Zefan wrote:
> 04:24, Tejun Heo wrote:
>> From: Sridhar Samudrala <samudrala.sridhar(a)gmail.com>
>>
>> Add a new kernel API to attach a task to current task's cgroup
>> in all the active hierarchies.
>>
>> Signed-off-by: Sridhar Samudrala <sri(a)us.ibm.com>
>
> Acked-by: Li Zefan <lizf(a)cn.fujitsu.com>
>
> btw: you lost the reviewed-by tag given by Paul Menage.

I only got bounced the original posting. Michael, can you please add
it if/when you commit these?

Thank you.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: writeback: tracing and wbc->nr_to_write fixes
Next: writeback: initial tracing support