drivers: regulator: add Maxim 8998 driver
in [Kernel]
|
From: Liam Girdwood on 16 Jun 2010 16:20 On Wed, 2010-06-16 at 15:30 +0100, Mark Brown wrote: > On Wed, Jun 16, 2010 at 09:04:16AM +0200, Marek Szyprowski wrote: > > From: Kyungmin Park <kyungmin.park(a)samsung.com> > > > > This patch adds voltage regulator driver for Maxim 8998 chip. This chip > > is used on Samsung Aquila and GONI boards and provides following > > functionalities: > > - 4 BUCK voltage converters, 17 LDO power regulators and 5 other power > > controllers > > - battery charger > > > > This patch adds basic driver for voltage regulators and MAX 8998 MFD core. > > > > Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com> > > Signed-off-by: Marek Szyprowski <m.szyprowski(a)samsung.com> > > Looks good! > > Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> Samuel, I can take the whole patch via regulator if necessary (providing I have your SoB for the mfd part). Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Marek Szyprowski on 17 Jun 2010 09:40 Hello, On Wednesday, June 16, 2010 4:31 PM Mark Brown wrote: > On Wed, Jun 16, 2010 at 09:04:16AM +0200, Marek Szyprowski wrote: > > From: Kyungmin Park <kyungmin.park(a)samsung.com> > > > > This patch adds voltage regulator driver for Maxim 8998 chip. This chip > > is used on Samsung Aquila and GONI boards and provides following > > functionalities: > > - 4 BUCK voltage converters, 17 LDO power regulators and 5 other power > > controllers > > - battery charger > > > > This patch adds basic driver for voltage regulators and MAX 8998 MFD core. > > > > Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com> > > Signed-off-by: Marek Szyprowski <m.szyprowski(a)samsung.com> > > Looks good! > > Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> I've just noticed one more thing. Shouldn't the max8998-pmic driver depend on max8998 mfd driver in Kconfig? Or maybe it would be better to select mfd driver from the regulators Kconfig? What do you think? Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Mark Brown on 17 Jun 2010 20:40 On Thu, Jun 17, 2010 at 03:35:35PM +0200, Marek Szyprowski wrote: > I've just noticed one more thing. Shouldn't the max8998-pmic driver depend > on max8998 mfd driver in Kconfig? Or maybe it would be better to select mfd > driver from the regulators Kconfig? What do you think? A dependency is what everything else is using. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Samuel Ortiz on 21 Jun 2010 06:30 Hi Liam, On Wed, Jun 16, 2010 at 09:16:43PM +0100, Liam Girdwood wrote: > On Wed, 2010-06-16 at 15:30 +0100, Mark Brown wrote: > > On Wed, Jun 16, 2010 at 09:04:16AM +0200, Marek Szyprowski wrote: > > > From: Kyungmin Park <kyungmin.park(a)samsung.com> > > > > > > This patch adds voltage regulator driver for Maxim 8998 chip. This chip > > > is used on Samsung Aquila and GONI boards and provides following > > > functionalities: > > > - 4 BUCK voltage converters, 17 LDO power regulators and 5 other power > > > controllers > > > - battery charger > > > > > > This patch adds basic driver for voltage regulators and MAX 8998 MFD core. > > > > > > Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com> > > > Signed-off-by: Marek Szyprowski <m.szyprowski(a)samsung.com> > > > > Looks good! > > > > Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> > > Samuel, I can take the whole patch via regulator if necessary (providing > I have your SoB for the mfd part). Yes, I just replied to Marek's v3 of the patch, by ACKing it. Thanks for carrying it via your tree. Cheers, Samuel. > Thanks > > Liam > -- > Freelance Developer, SlimLogic Ltd > ASoC and Voltage Regulator Maintainer. > http://www.slimlogic.co.uk > -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Samuel Ortiz on 21 Jun 2010 06:30 On Wed, Jun 16, 2010 at 09:04:16AM +0200, Marek Szyprowski wrote: > From: Kyungmin Park <kyungmin.park(a)samsung.com> > > This patch adds voltage regulator driver for Maxim 8998 chip. This chip > is used on Samsung Aquila and GONI boards and provides following > functionalities: > - 4 BUCK voltage converters, 17 LDO power regulators and 5 other power > controllers > - battery charger > > This patch adds basic driver for voltage regulators and MAX 8998 MFD core. > > Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com> > Signed-off-by: Marek Szyprowski <m.szyprowski(a)samsung.com> Looks good to me: Acked-by: Samuel Ortiz <sameo(a)linux.intel.com> Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
First
|
Prev
|
Next
|
Last
Pages: 1 2 3 4 Prev: AT91: add new at91 chips in at91sam9g45 family Next: [PATCH] smb380: accelerometer driver |