From: Alan Cox on
> But not only is Fedora not following the rules,

You changed the rules. You require a Signed-off-by:. Fedora can no more
add a signed off by than you can. It's not their code nor Red Hat's code
any more than they "own" the kernel because they pay someone to work on
it.

> See above. It's not you. It's Fedora. If Fedora hadn't merged Nouveau and
> shipped it, I wouldn't care.

And zillions of Nvidia users would have been worse off.

It's really simple: if you want to merge it *you* pull it and sign it off.
If you aren't prepared to do that then ask why Fedora should, its not
their code either.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Linus Torvalds on


On Thu, 10 Dec 2009, Alan Cox wrote:
>
> > But not only is Fedora not following the rules,
>
> You changed the rules. You require a Signed-off-by:. Fedora can no more
> add a signed off by than you can. It's not their code nor Red Hat's code
> any more than they "own" the kernel because they pay someone to work on
> it.

You're avoiding the point: they are shipping it, they are paying for (at
least some) development, and they seem to not even want to face the issue.

Sign-offs aren't some new feature that took Red Hat people by surprise.
The "get it merged upstream first" didn't change in any way from it: it
just codified existing practice - of _course_ everybody expects copyrights
to be honored and clear.

> It's really simple: if you want to merge it *you* pull it and sign it off.
> If you aren't prepared to do that then ask why Fedora should, its not
> their code either.

I'm not shipping it. They are. That's the difference.

I realize that you have some emotional attachments to Red Hat, but ask
yourself (and answer honestly): what would you think if some random other
distro was packaging tens of thousands of lines of kernel code and not
apparently working at trying to get them upstream?

Dave claims it's only been going on for a few months, but quite frankly,
we all know better. The nouveau kernel modules have been shipped for a lot
longer than just F12.

And it's possible that other distros are doing the same thing. I happen to
know that Fedora does it (and has been doing it for at least a year),
because I happen to have an Intel development machine that runs Fedora and
was shipped by Intel with an nVidia card (and has a power supply that
craps out if you don't use several hundred watts of power, so I can't
change it to something more power-efficient - seriously).

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: C. Bergström on
Linus Torvalds wrote:
> On Thu, 10 Dec 2009, Alan Cox wrote:
>
>>> But not only is Fedora not following the rules,
>>>
>> You changed the rules. You require a Signed-off-by:. Fedora can no more
>> add a signed off by than you can. It's not their code nor Red Hat's code
>> any more than they "own" the kernel because they pay someone to work on
>> it.
>>
>
> You're avoiding the point: they are shipping it, they are paying for (at
> least some) development, and they seem to not even want to face the issue.
>
> Sign-offs aren't some new feature that took Red Hat people by surprise.
> The "get it merged upstream first" didn't change in any way from it: it
> just codified existing practice - of _course_ everybody expects copyrights
> to be honored and clear.
>
>
>> It's really simple: if you want to merge it *you* pull it and sign it off.
>> If you aren't prepared to do that then ask why Fedora should, its not
>> their code either.
>>
>
> I'm not shipping it. They are. That's the difference.
>
> I realize that you have some emotional attachments to Red Hat, but ask
> yourself (and answer honestly): what would you think if some random other
> distro was packaging tens of thousands of lines of kernel code and not
> apparently working at trying to get them upstream?
>
> Dave claims it's only been going on for a few months, but quite frankly,
> we all know better. The nouveau kernel modules have been shipped for a lot
> longer than just F12.
>
> And it's possible that other distros are doing the same thing. I happen to
> know that Fedora does it (and has been doing it for at least a year),
> because I happen to have an Intel development machine that runs Fedora and
> was shipped by Intel with an nVidia card (and has a power supply that
> craps out if you don't use several hundred watts of power, so I can't
> change it to something more power-efficient - seriously).
>
Thanks for the rather lengthly explanation, but in case you missed what
people are trying to say here..

With all due respect Linus..

"patches welcome"

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Linus Torvalds on


On Thu, 10 Dec 2009, "C. Bergstr�m" wrote:
>
> Thanks for the rather lengthly explanation, but in case you missed what people
> are trying to say here..
>
> With all due respect Linus..
>
> "patches welcome"

The problem is that I have never even heard a Red Hat or Fedora person
actually acknoledge that yes, they should be trying to upstream it.

Have Red Hat and Fedora just decided that "upstream first" simply doesn't
matter any more? Because quite frankly, that was kind of the feeling I
came away with from the Kernel summit.

It's like they _want_ to keep it internal.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Dave Airlie on
2009/12/11 Linus Torvalds <torvalds(a)linux-foundation.org>:
>
>
> On Thu, 10 Dec 2009, "C. Bergstr�m" wrote:
>>
>> Thanks for the rather lengthly explanation, but in case you missed what people
>> are trying to say here..
>>
>> With all due respect Linus..
>>
>> "patches welcome"
>
> The problem is that I have never even heard a Red Hat or Fedora person
> actually acknoledge that yes, they should be trying to upstream it.

<Red Hat hat on>
<Fedora hat on>
We are trying to upstream nouveau.
<Fedora hat off>
<Red Hat hat off>

<DRM maintainer hat on>
The core DRM changes to support nouveau were but ugly, and shared
with radeon and vmware, we need to wait for VMware to re-write them.
VMware have rewritten them and they are upstream since radeon KMS
got merged into staging.
<DRM maintainer hat off>

<nouveau reviewer hat on>
The ctxprogs are legally dubious, we need to wait for Red Hat lawyers
to give us some direction, we can involve other lawyers but more
lawyers doesn't always help these things go faster.
<nouveau reviewer hat off>

<Dave hat on>
nvidia guys are laughing at us.
<Dave hat off>

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/