ftrace.h: Use common pr_info fmt string
in [Kernel]
|
Prev: 2.6.32-git5+, CONFIG_WEXT_PRIV and Broadcom's driver for BCM4322 Wireless chips
Next: [RFC] Convert Documentation/ to asciidoc?
From: Frederic Weisbecker on 13 Dec 2009 10:00 On Sun, Dec 13, 2009 at 09:48:15AM -0500, Steven Rostedt wrote: > On Sun, 2009-12-13 at 07:37 +0000, tip-bot for Joe Perches wrote: > > Commit-ID: 4819568f23a8bef0ca99b740ca60fe2450ab0aac > > Gitweb: http://git.kernel.org/tip/4819568f23a8bef0ca99b740ca60fe2450ab0aac > > Author: Joe Perches <joe(a)perches.com> > > AuthorDate: Sat, 12 Dec 2009 13:06:13 -0800 > > Committer: Ingo Molnar <mingo(a)elte.hu> > > CommitDate: Sun, 13 Dec 2009 08:14:45 +0100 > > > > ftrace.h: Use common pr_info fmt string > > > > Reduces fmt string space a bit. > > > > Signed-off-by: Joe Perches <joe(a)perches.com> > > Cc: Frederic Weisbecker <fweisbec(a)gmail.com> > > Cc: Steven Rostedt <rostedt(a)goodmis.org> > > LKML-Reference: <1260651974.2637.4.camel(a)Joe-Laptop.home> > > Signed-off-by: Ingo Molnar <mingo(a)elte.hu> > > --- > > include/trace/ftrace.h | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h > > index d1b3de9..c4eca38 100644 > > --- a/include/trace/ftrace.h > > +++ b/include/trace/ftrace.h > > @@ -733,7 +733,7 @@ static int ftrace_raw_reg_event_##call(struct ftrace_event_call *unused)\ > > ret = register_trace_##call(ftrace_raw_event_##call); \ > > if (ret) \ > > pr_info("event trace: Could not activate trace point " \ > > - "probe to " #call "\n"); \ > > + "probe to %s\n", #call); \ > > This reduces format string space a bit, but doesn't it just add another > string to the string tables #func == "func" as well as add code to pass > in another parameter? > > -- Steve Yeah, I don't understand the purpose of this patch either... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Joe Perches on 13 Dec 2009 13:00 On Sun, 2009-12-13 at 15:50 +0100, Frederic Weisbecker wrote: > On Sun, Dec 13, 2009 at 09:48:15AM -0500, Steven Rostedt wrote: > > > pr_info("event trace: Could not activate trace point " \ > > > - "probe to " #call "\n"); \ > > > + "probe to %s\n", #call); \ > > This reduces format string space a bit, but doesn't it just add another > > string to the string tables #func == "func" as well as add code to pass > > in another parameter? > Yeah, I don't understand the purpose of this patch either... For sched, it reduces size by ~1k. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Joe Perches on 13 Dec 2009 13:40 On Sun, 2009-12-13 at 15:50 +0100, Frederic Weisbecker wrote: > On Sun, Dec 13, 2009 at 09:48:15AM -0500, Steven Rostedt wrote: > > > pr_info("event trace: Could not activate trace point " \ > > > - "probe to " #call "\n"); \ > > > + "probe to %s\n", #call); \ > > This reduces format string space a bit, but doesn't it just add another > > string to the string tables #func == "func" as well as add code to pass > > in another parameter? > Yeah, I don't understand the purpose of this patch either... The patch from Li Zefan you've already queued is better http://lkml.org/lkml/2009/12/13/60 Subject: [PATCH 03/13] tracing: Move a printk out of ftrace_raw_reg_event_foo() Date: Sun, 13 Dec 2009 14:08:04 +0100 From: Li Zefan <lizf(a)cn.fujitsu.com> Move the printk from each ftrace_raw_reg_event_foo() to its caller ftrace_event_enable_disable(). This avoids each regfunc trace event callbacks to handle a same error report that can be carried from the caller. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Frederic Weisbecker on 13 Dec 2009 16:30
On Sun, Dec 13, 2009 at 10:33:27AM -0800, Joe Perches wrote: > On Sun, 2009-12-13 at 15:50 +0100, Frederic Weisbecker wrote: > > On Sun, Dec 13, 2009 at 09:48:15AM -0500, Steven Rostedt wrote: > > > > pr_info("event trace: Could not activate trace point " \ > > > > - "probe to " #call "\n"); \ > > > > + "probe to %s\n", #call); \ > > > This reduces format string space a bit, but doesn't it just add another > > > string to the string tables #func == "func" as well as add code to pass > > > in another parameter? > > Yeah, I don't understand the purpose of this patch either... > > The patch from Li Zefan you've already queued is better > > http://lkml.org/lkml/2009/12/13/60 Ok. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |