hpwdt: make NMI code a config option (+ other cleanup)
in [Kernel]
|
Prev: USB: gadget: storage_common: fixed warning building mass storage function
Next: Please pull from lost-spurious-irq
From: Mingarelli, Thomas on 28 Jul 2010 09:20 Acked-By: Tom Mingarelli <Thomas.mingarelli(a)hp.com> > -----Original Message----- > From: Frazier, Daniel Kent (ProLiant Linux) > Sent: Tuesday, July 27, 2010 6:51 PM > To: Wim Van Sebroeck > Cc: linux-kernel(a)vger.kernel.org; Mingarelli, Thomas > Subject: [PATCH 00/15] hpwdt: make NMI code a config option (+ other > cleanup) > > hwpdt includes an NMI-decoding feature, but the watchdog interface is > quite > usable without it. This patchset makes it possible to build hpwdt without > the > NMI functionality, as well as some general cleanup. > > Kconfig | 22 +++++-- > hpwdt.c | 181 ++++++++++++++++++++++++++++++++++++---------------------- > ------ > 2 files changed, 119 insertions(+), 84 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: dann frazier on 6 Aug 2010 17:30 On Fri, Aug 06, 2010 at 11:26:48PM +0200, Wim Van Sebroeck wrote: > Hi Dan, > > > So overall: patches look good, but let's re-order the patches a bit (so that we first clean-up the driver and then add the NMI related changes (If we ever need to revert some things then we at least have a clean-driver before we start bisecting the NMI changes)). > > And secondly: let's try to have the ifdef's out of the init and exit procedures. > > > > If you can look at how we can get rid of the ifdef's in init and exit, then I will reorder the patches and change the 3 timer patches and put that allready in a git tree. > > I reorganised the sequence of patches. I'll sent them to you for verification (and will put a copy in linux-watchdog mailing list). > > the patches now look like: > watchdog: hpwdt (1/12): clean-up include-files. > watchdog: hpwdt (2/12): Group options that affect watchdog behavior together > watchdog: hpwdt (3/12): Group NMI sourcing specific items together > watchdog: hpwdt (4/12): Despecificate driver from iLO2 > watchdog: hpwdt (5/12): Make x86 assembly ifdef guard more strict > watchdog: hpwdt (6/12): Introduce SECS_TO_TICKS() macro > watchdog: hpwdt (7/12): allow full range of timer values supported by hardware > watchdog: hpwdt (8/12): implement WDIOC_GETTIMELEFT > watchdog: hpwdt (9/12): hpwdt_pretimeout reorganization > watchdog: hpwdt (10/12): Construct status message w/ kasprintf and emit it with dev_info > watchdog: hpwdt (11/12): Use "decoding" instead of "sourcing" > watchdog: hpwdt (12/12): Make NMI decoding a compile-time option > > (patch 12 can still be improved). Thanks! I'll work on the #ifdef'ing & get you a new #12 -- dann frazier | ProLiant Linux -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: dann frazier on 13 Aug 2010 03:30
On Wed, Aug 11, 2010 at 02:49:11PM +0200, Wim Van Sebroeck wrote: > Hi Dan, > > > > watchdog: hpwdt (10/12): Construct status message w/ kasprintf and emit it with dev_info > > > watchdog: hpwdt (11/12): Use "decoding" instead of "sourcing" > > > watchdog: hpwdt (12/12): Make NMI decoding a compile-time option > > > > > > (patch 12 can still be improved). > > > > Thanks! I'll work on the #ifdef'ing & get you a new #12 > > I did some changes in the last 3 patches: > I removed patch 10, made patch 11 patch 10 and added and extra patch that moves the nmi decoding init and exit functions in seperate modules. > I'll sent you the 3 new patches. Just let me know if they are OK. Yes, they look very much like the changes I was preparing - but I got sidetracked by vacation before I could test :) I pulled your tree & ran a few sanity tests - looks good. Thanks for doing this! -- dann frazier | ProLiant Linux -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |