Prev: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
Next: isdn: Cleanup Sections in PCMCIA driver avma1
From: Dominik Brodowski on 25 Mar 2010 13:30
Karsten, will you carry these fixes upstream, or shall I do?

Best,
Dominik

On Thu, Mar 25, 2010 at 01:13:18PM +0100, Karsten Keil wrote:
> On Donnerstag, 25. M�rz 2010 13:05:29 Henrik Kretzschmar wrote:
> > Compiling this driver gave a section mismatch,
> > so I reviewed the init/exit paths of the driver
> > and made the correct changes.
> >
> > WARNING: drivers/isdn/hisax/built-in.o(.text+0x558d6): Section mismatch
> > in reference from the function sedlbauer_config() to the function
> > .devinit.text:hisax_init_pcmcia()
> > The function sedlbauer_config() references
> > the function __devinit hisax_init_pcmcia().
> > This is often because sedlbauer_config lacks a __devinit
> > annotation or the annotation of hisax_init_pcmcia is wrong.
> >
> > Signed-off-by: Henrik Kretzschmar <henne(a)nachtwindheim.de>
> Acked-by: <keil(a)b1-systems.de>
>
> Thank you for fixing this.
> l
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on 25 Mar 2010 14:50
From: Dominik Brodowski <linux(a)dominikbrodowski.net>
Date: Thu, 25 Mar 2010 18:02:40 +0100

> Karsten, will you carry these fixes upstream, or shall I do?

I'll apply them.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on 25 Mar 2010 15:00
From: David Miller <davem(a)davemloft.net>
Date: Thu, 25 Mar 2010 11:45:48 -0700 (PDT)

> From: Dominik Brodowski <linux(a)dominikbrodowski.net>
> Date: Thu, 25 Mar 2010 18:02:40 +0100
>
>> Karsten, will you carry these fixes upstream, or shall I do?
>
> I'll apply them.

BTW, please CC: netdev on ISDN patches in the future.

I'll add some material to the MAINTAINERS if there isn't
a mention about this there already.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Henrik Kretzschmar on 25 Mar 2010 21:00
David Miller schrieb:
> From: Karsten Keil <isdn(a)linux-pingi.de>
> Date: Thu, 25 Mar 2010 13:13:18 +0100
>
>
>> On Donnerstag, 25. M�rz 2010 13:05:29 Henrik Kretzschmar wrote:
>>
>>> Compiling this driver gave a section mismatch,
>>> so I reviewed the init/exit paths of the driver
>>> and made the correct changes.
>>>
>>> WARNING: drivers/isdn/hisax/built-in.o(.text+0x558d6): Section mismatch
>>> in reference from the function sedlbauer_config() to the function
>>> .devinit.text:hisax_init_pcmcia()
>>> The function sedlbauer_config() references
>>> the function __devinit hisax_init_pcmcia().
>>> This is often because sedlbauer_config lacks a __devinit
>>> annotation or the annotation of hisax_init_pcmcia is wrong.
>>>
>>> Signed-off-by: Henrik Kretzschmar <henne(a)nachtwindheim.de>
>>>
>> Acked-by: <keil(a)b1-systems.de>
>>
>> Thank you for fixing this.
>>
>
> Thanks for reviewing Karsten.
>
> Please put your proper name in your ACK lines in the
> future, they should look just like Signed-off-by: lines.
>
> I fixed this up when committing, thanks again.
>
>
Hi David,

I've seen that you put the patches on the net-tree. Thats fine.
In the author field my real name "Henrik Kretzschmar" was replaced by "Henne" somehow.
That's not a problem for me, but I just wanted to have you noticed about that.

Greets Henrik

P.S. cc-ing to netdev is okay.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on 25 Mar 2010 23:30
From: Henrik Kretzschmar <henne(a)nachtwindheim.de>
Date: Fri, 26 Mar 2010 01:59:07 +0100

> I've seen that you put the patches on the net-tree. Thats fine. In
> the author field my real name "Henrik Kretzschmar" was replaced by
> "Henne" somehow. That's not a problem for me, but I just wanted to
> have you noticed about that

That's what the From: fields were in your patch postings are
recorded by patchwork.kernel.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
First  |  Prev  |  Next  |  Last
Pages: 1 2 3
Prev: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
Next: isdn: Cleanup Sections in PCMCIA driver avma1