kernel.h hexdump cleanup
in [Kernel]
|
Prev: [PATCH v2 11/12] ACPI: processor: push file static MADT pointer into internal map_madt_entry()
Next: backlight: mark struct backlight_ops const
From: Mike Frysinger on 22 Feb 2010 14:40 On Mon, Feb 22, 2010 at 09:19, Dave Young wrote: > --- /dev/null 1970-01-01 00:00:00.000000000 +0000 > +++ linux-2.6/include/linux/hexdump.h 2010-02-16 17:33:16.000000000 +0800 > @@ -0,0 +1,30 @@ > +#ifndef _HEXDUMP_H > +#define _HEXDUMP_H use _LINUX_HEXDUMP_H to match other linux/ headers ? -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Joe Perches on 22 Feb 2010 14:50 On Mon, 2010-02-22 at 22:19 +0800, Dave Young wrote: > hexdump stuff in kernel.h should be put into a standalone head file I think it'd be clearer to have logging functions in kernel.h split into a separate header or grouped a bit better in kernel.h. I would have kernel.h #include that header though rather than splitting out things like hexdump functions into a separate file requiring yet another #include in source files. http://lkml.org/lkml/2009/12/16/77 http://lkml.org/lkml/2007/11/29/507 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Dave Young on 24 Feb 2010 21:00 On Tue, Feb 23, 2010 at 3:43 AM, Joe Perches <joe(a)perches.com> wrote: > On Mon, 2010-02-22 at 22:19 +0800, Dave Young wrote: >> hexdump stuff in kernel.h should be put into a standalone head file > > I think it'd be clearer to have logging functions > in kernel.h split into a separate header or grouped > a bit better in kernel.h. > > I would have kernel.h #include that header though > rather than splitting out things like hexdump functions > into a separate file requiring yet another #include in > source files. Andrew, what do you think about this? Actually I hesitate to send this patch as well, too many recipients needed from get_maintainer.pl. > > http://lkml.org/lkml/2009/12/16/77 > http://lkml.org/lkml/2007/11/29/507 > > > -- Regards dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Andrew Morton on 24 Feb 2010 21:20 On Thu, 25 Feb 2010 09:52:49 +0800 Dave Young <hidave.darkstar(a)gmail.com> wrote: > On Tue, Feb 23, 2010 at 3:43 AM, Joe Perches <joe(a)perches.com> wrote: > > On Mon, 2010-02-22 at 22:19 +0800, Dave Young wrote: > >> hexdump stuff in kernel.h should be put into a standalone head file > > > > I think it'd be clearer to have logging functions > > in kernel.h split into a separate header or grouped > > a bit better in kernel.h. > > > > I would have kernel.h #include that header though > > rather than splitting out things like hexdump functions > > into a separate file requiring yet another #include in > > source files. > > Andrew, what do you think about this? Well. Avoiding bisection-bustage is hardly a priority any more, but let's not break bisection this time if we can avoid it. > Actually I hesitate to send this patch as well, too many recipients > needed from get_maintainer.pl. They'll live ;) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Dave Young on 24 Feb 2010 22:30
On Thu, Feb 25, 2010 at 10:16 AM, Andrew Morton <akpm(a)linux-foundation.org> wrote: > On Thu, 25 Feb 2010 09:52:49 +0800 Dave Young <hidave.darkstar(a)gmail.com> wrote: > >> On Tue, Feb 23, 2010 at 3:43 AM, Joe Perches <joe(a)perches.com> wrote: >> > On Mon, 2010-02-22 at 22:19 +0800, Dave Young wrote: >> >> hexdump stuff in kernel.h should be put into a standalone head file >> > >> > I think it'd be clearer to have logging functions >> > in kernel.h split into a separate header or grouped >> > a bit better in kernel.h. >> > >> > I would have kernel.h #include that header though >> > rather than splitting out things like hexdump functions >> > into a separate file requiring yet another #include in >> > source files. >> >> Andrew, what do you think about this? > > Well. Avoiding bisection-bustage is hardly a priority any more, but > let's not break bisection this time if we can avoid it. Thanks, see it. > >> Actually I hesitate to send this patch as well, too many recipients >> needed from get_maintainer.pl. > > They'll live ;) > -- Regards dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |