linux-next: build failure after merge of the final tree (scsi-post-merge tree related)
in [Kernel]
|
Prev: linux-next: build failure after merge of the final tree (tip tree related)
Next: linux-next: build failure after merge of the final tree (scsi-post-merge tree related)
From: Stephen Rothwell on 2 Aug 2010 12:50 Hi , After merging the final tree, today's linux-next build (powerpc allmodconfig) failed like this: ERROR: ".iscsi_boot_destroy_kset" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined! ERROR: ".iscsi_boot_create_host_kset" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined! ERROR: ".iscsi_boot_create_target" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined! ERROR: ".iscsi_boot_create_initiator" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined! ERROR: ".iscsi_boot_create_ethernet" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined! Caused by commit a33e2a708b2e83ee6111e45c8d3d49a112c3c887 ("[SCSI] be2iscsi: Add support for iscsi boot"). For some reason, commit ed94aa526655d915076dcdbbf4fc962b2a67fcb5 ("[SCSI] be2iscsi: select ISCSI_BOOT_SYSFS") was not sufficient to make sure that CONFIG_ISCSI_BOOT_SYSFS is defined for this build. -- Cheers, Stephen Rothwell sfr(a)canb.auug.org.au http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell on 2 Aug 2010 12:50 Hi all, On Tue, 3 Aug 2010 02:44:45 +1000 Stephen Rothwell <sfr(a)canb.auug.org.au> wrote: > > After merging the final tree, today's linux-next build (powerpc allmodconfig) > failed like this: > > ERROR: ".iscsi_boot_destroy_kset" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined! > ERROR: ".iscsi_boot_create_host_kset" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined! > ERROR: ".iscsi_boot_create_target" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined! > ERROR: ".iscsi_boot_create_initiator" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined! > ERROR: ".iscsi_boot_create_ethernet" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined! > > Caused by commit a33e2a708b2e83ee6111e45c8d3d49a112c3c887 ("[SCSI] > be2iscsi: Add support for iscsi boot"). For some reason, commit > ed94aa526655d915076dcdbbf4fc962b2a67fcb5 ("[SCSI] be2iscsi: select > ISCSI_BOOT_SYSFS") was not sufficient to make sure that > CONFIG_ISCSI_BOOT_SYSFS is defined for this build. It turns out that drivers/firmware/Kconfig is only included on x86, ia64 and blackfin. -- Cheers, Stephen Rothwell sfr(a)canb.auug.org.au http://www.canb.auug.org.au/~sfr/
From: James Bottomley on 2 Aug 2010 13:00 missing linux-scsi added to cc list. On Tue, 2010-08-03 at 02:47 +1000, Stephen Rothwell wrote: > Hi all, > > On Tue, 3 Aug 2010 02:44:45 +1000 Stephen Rothwell <sfr(a)canb.auug.org.au> wrote: > > > > After merging the final tree, today's linux-next build (powerpc allmodconfig) > > failed like this: > > > > ERROR: ".iscsi_boot_destroy_kset" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined! > > ERROR: ".iscsi_boot_create_host_kset" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined! > > ERROR: ".iscsi_boot_create_target" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined! > > ERROR: ".iscsi_boot_create_initiator" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined! > > ERROR: ".iscsi_boot_create_ethernet" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined! > > > > Caused by commit a33e2a708b2e83ee6111e45c8d3d49a112c3c887 ("[SCSI] > > be2iscsi: Add support for iscsi boot"). For some reason, commit > > ed94aa526655d915076dcdbbf4fc962b2a67fcb5 ("[SCSI] be2iscsi: select > > ISCSI_BOOT_SYSFS") was not sufficient to make sure that > > CONFIG_ISCSI_BOOT_SYSFS is defined for this build. > > It turns out that drivers/firmware/Kconfig is only included on x86, ia64 > and blackfin. OK, we need to turn this around then and make be2iscsi only use iscsi boot if it's enabled ... that's going to be some fun #ifdefing in the driver. James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: James Bottomley on 2 Aug 2010 16:20 On Mon, 2010-08-02 at 15:59 -0400, Konrad Rzeszutek Wilk wrote: > > >Yikes. Last minute change, eh? > > > > I do not know what you mean. The patches always had iscsi_boot_sysfs in > > the firmware dir. You mean this is a last minute change? > > Yes, this rename. > > > > > > > >>interface is generic and should be used on any arch and with anything > > >>(ibft or iscsi driver) that wants to export iscsi boot info. The > > >>attached patch moves iscsi_boot_sysfs to drivers/scsi. It was made over > > >>linux-next. I have only compile tested it. > > > > > >did you compile test it with the x86 native iBFT driver? > > > > Yes. > > Excellent. The patch does not look like it has changed at all, so: > > 1). Signed-off-by: Konrad Rzeszutek Wilk <konrad(a)kernel.org> > for the removal from firmware/ibft, and > 2). Reviewed-by: Konrad Rzeszutek Wilk <konrad(a)kernel.org> for the > the part that puts in drivers/scsi and will make it now under James' > mainternship. > > James, > > I've asked Linus to pull my iBFT tree before yours as there was this > dependency. Are you OK putting this patch in your tree, or would you prefer > that I expunge Mike's patch from mine? I can put this patch into my post merge tree. I suspect you having a post-post-merge tree (needed for the build problems) might be a bit overkill ... James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Stephen Rothwell on 4 Aug 2010 22:00
Hi James, On Mon, 02 Aug 2010 15:14:02 -0500 James Bottomley <James.Bottomley(a)suse.de> wrote: > > On Mon, 2010-08-02 at 15:59 -0400, Konrad Rzeszutek Wilk wrote: > > > >Yikes. Last minute change, eh? > > > > > > I do not know what you mean. The patches always had iscsi_boot_sysfs in > > > the firmware dir. You mean this is a last minute change? > > > > Yes, this rename. > > > > > > > > > > >>interface is generic and should be used on any arch and with anything > > > >>(ibft or iscsi driver) that wants to export iscsi boot info. The > > > >>attached patch moves iscsi_boot_sysfs to drivers/scsi. It was made over > > > >>linux-next. I have only compile tested it. > > > > > > > >did you compile test it with the x86 native iBFT driver? > > > > > > Yes. > > > > Excellent. The patch does not look like it has changed at all, so: > > > > 1). Signed-off-by: Konrad Rzeszutek Wilk <konrad(a)kernel.org> > > for the removal from firmware/ibft, and > > 2). Reviewed-by: Konrad Rzeszutek Wilk <konrad(a)kernel.org> for the > > the part that puts in drivers/scsi and will make it now under James' > > mainternship. > > > > James, > > > > I've asked Linus to pull my iBFT tree before yours as there was this > > dependency. Are you OK putting this patch in your tree, or would you prefer > > that I expunge Mike's patch from mine? > > I can put this patch into my post merge tree. I suspect you having a > post-post-merge tree (needed for the build problems) might be a bit > overkill ... Ping? -- Cheers, Stephen Rothwell sfr(a)canb.auug.org.au http://www.canb.auug.org.au/~sfr/ |