From: Mike Christie on
On 08/02/2010 11:47 AM, Stephen Rothwell wrote:
> Hi all,
>
> On Tue, 3 Aug 2010 02:44:45 +1000 Stephen Rothwell<sfr(a)canb.auug.org.au> wrote:
>>
>> After merging the final tree, today's linux-next build (powerpc allmodconfig)
>> failed like this:
>>
>> ERROR: ".iscsi_boot_destroy_kset" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
>> ERROR: ".iscsi_boot_create_host_kset" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
>> ERROR: ".iscsi_boot_create_target" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
>> ERROR: ".iscsi_boot_create_initiator" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
>> ERROR: ".iscsi_boot_create_ethernet" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
>>
>> Caused by commit a33e2a708b2e83ee6111e45c8d3d49a112c3c887 ("[SCSI]
>> be2iscsi: Add support for iscsi boot"). For some reason, commit
>> ed94aa526655d915076dcdbbf4fc962b2a67fcb5 ("[SCSI] be2iscsi: select
>> ISCSI_BOOT_SYSFS") was not sufficient to make sure that
>> CONFIG_ISCSI_BOOT_SYSFS is defined for this build.
>
> It turns out that drivers/firmware/Kconfig is only included on x86, ia64
> and blackfin.
>

I think the iscsi_boot_sysfs module should just be moved to
drivers/scsi. It is a generic scsi/iscsi interface to export iscsi boot
info and is not tied to boot. I will send a patch in a couple minutes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Mike Christie on
On 08/02/2010 11:54 AM, James Bottomley wrote:
> missing linux-scsi added to cc list.
>
> On Tue, 2010-08-03 at 02:47 +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> On Tue, 3 Aug 2010 02:44:45 +1000 Stephen Rothwell<sfr(a)canb.auug.org.au> wrote:
>>>
>>> After merging the final tree, today's linux-next build (powerpc allmodconfig)
>>> failed like this:
>>>
>>> ERROR: ".iscsi_boot_destroy_kset" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
>>> ERROR: ".iscsi_boot_create_host_kset" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
>>> ERROR: ".iscsi_boot_create_target" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
>>> ERROR: ".iscsi_boot_create_initiator" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
>>> ERROR: ".iscsi_boot_create_ethernet" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
>>>
>>> Caused by commit a33e2a708b2e83ee6111e45c8d3d49a112c3c887 ("[SCSI]
>>> be2iscsi: Add support for iscsi boot"). For some reason, commit
>>> ed94aa526655d915076dcdbbf4fc962b2a67fcb5 ("[SCSI] be2iscsi: select
>>> ISCSI_BOOT_SYSFS") was not sufficient to make sure that
>>> CONFIG_ISCSI_BOOT_SYSFS is defined for this build.
>>
>> It turns out that drivers/firmware/Kconfig is only included on x86, ia64
>> and blackfin.
>
> OK, we need to turn this around then and make be2iscsi only use iscsi
> boot if it's enabled ... that's going to be some fun #ifdefing in the
> driver.
>

I think my mistake was to put iscsi_boot_sysfs in drivers/firmware. The
interface is generic and should be used on any arch and with anything
(ibft or iscsi driver) that wants to export iscsi boot info. The
attached patch moves iscsi_boot_sysfs to drivers/scsi. It was made over
linux-next. I have only compile tested it.
From: Mike Christie on
On 08/02/2010 01:59 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, Aug 02, 2010 at 12:46:12PM -0500, Mike Christie wrote:
>> On 08/02/2010 11:54 AM, James Bottomley wrote:
>>> missing linux-scsi added to cc list.
>>>
>>> On Tue, 2010-08-03 at 02:47 +1000, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> On Tue, 3 Aug 2010 02:44:45 +1000 Stephen Rothwell<sfr(a)canb.auug.org.au>
>>>> wrote:
>>>>>
>>>>> After merging the final tree, today's linux-next build (powerpc
>>>>> allmodconfig)
>>>>> failed like this:
>>>>>
>>>>> ERROR: ".iscsi_boot_destroy_kset" [drivers/scsi/be2iscsi/be2iscsi.ko]
>>>>> undefined!
>>>>> ERROR: ".iscsi_boot_create_host_kset"
>>>>> [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
>>>>> ERROR: ".iscsi_boot_create_target" [drivers/scsi/be2iscsi/be2iscsi.ko]
>>>>> undefined!
>>>>> ERROR: ".iscsi_boot_create_initiator"
>>>>> [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
>>>>> ERROR: ".iscsi_boot_create_ethernet" [drivers/scsi/be2iscsi/be2iscsi.ko]
>>>>> undefined!
>>>>>
>>>>> Caused by commit a33e2a708b2e83ee6111e45c8d3d49a112c3c887 ("[SCSI]
>>>>> be2iscsi: Add support for iscsi boot"). For some reason, commit
>>>>> ed94aa526655d915076dcdbbf4fc962b2a67fcb5 ("[SCSI] be2iscsi: select
>>>>> ISCSI_BOOT_SYSFS") was not sufficient to make sure that
>>>>> CONFIG_ISCSI_BOOT_SYSFS is defined for this build.
>>>>
>>>> It turns out that drivers/firmware/Kconfig is only included on x86, ia64
>>>> and blackfin.
>>>
>>> OK, we need to turn this around then and make be2iscsi only use iscsi
>>> boot if it's enabled ... that's going to be some fun #ifdefing in the
>>> driver.
>>>
>>
>> I think my mistake was to put iscsi_boot_sysfs in drivers/firmware. The
>
> Yikes. Last minute change, eh?

I do not know what you mean. The patches always had iscsi_boot_sysfs in
the firmware dir. You mean this is a last minute change?

>
>> interface is generic and should be used on any arch and with anything
>> (ibft or iscsi driver) that wants to export iscsi boot info. The
>> attached patch moves iscsi_boot_sysfs to drivers/scsi. It was made over
>> linux-next. I have only compile tested it.
>
> did you compile test it with the x86 native iBFT driver?

Yes.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/