mfd: max8998 - fix incorrect kfree(i2c) in i2c_driver probe callback handler
in [Kernel]
|
Prev: [PATCH RESEND again] regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write()
Next: [TRIVIAL] fix some (printk) typos: faild and Faild
From: Samuel Ortiz on 9 Aug 2010 05:20 Hi Axel, On Mon, Aug 09, 2010 at 02:48:16PM +0800, Axel Lin wrote: > The i2c_client received in probe() should not be kfree()'d. This should go through Liam's tree, I'm CC'ing him to this thread. Cheers, Samuel. > Signed-off-by: Axel Lin <axel.lin(a)gmail.com> > --- > drivers/mfd/max8998.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c > index 0d68de2..73e6f5c 100644 > --- a/drivers/mfd/max8998.c > +++ b/drivers/mfd/max8998.c > @@ -89,10 +89,8 @@ static int max8998_i2c_probe(struct i2c_client *i2c, > int ret = 0; > > max8998 = kzalloc(sizeof(struct max8998_dev), GFP_KERNEL); > - if (max8998 == NULL) { > - kfree(i2c); > + if (max8998 == NULL) > return -ENOMEM; > - } > > i2c_set_clientdata(i2c, max8998); > max8998->dev = &i2c->dev; > -- > 1.5.4.3 > > > -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Liam Girdwood on 9 Aug 2010 05:40 On Mon, 2010-08-09 at 11:15 +0200, Samuel Ortiz wrote: > Hi Axel, > > On Mon, Aug 09, 2010 at 02:48:16PM +0800, Axel Lin wrote: > > The i2c_client received in probe() should not be kfree()'d. > This should go through Liam's tree, I'm CC'ing him to this thread. Thanks, I assume I have you Ack too ? Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Samuel Ortiz on 9 Aug 2010 05:50 On Mon, Aug 09, 2010 at 10:36:12AM +0100, Liam Girdwood wrote: > On Mon, 2010-08-09 at 11:15 +0200, Samuel Ortiz wrote: > > Hi Axel, > > > > On Mon, Aug 09, 2010 at 02:48:16PM +0800, Axel Lin wrote: > > > The i2c_client received in probe() should not be kfree()'d. > > This should go through Liam's tree, I'm CC'ing him to this thread. > > Thanks, I assume I have you Ack too ? Yup, sorry about that: Signed-off-by: Samuel Ortiz <sameo(a)linux.intel.com> Cheers, Samuel. > Thanks > > Liam > -- > Freelance Developer, SlimLogic Ltd > ASoC and Voltage Regulator Maintainer. > http://www.slimlogic.co.uk > -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Liam Girdwood on 9 Aug 2010 06:10
On Mon, 2010-08-09 at 11:44 +0200, Samuel Ortiz wrote: > On Mon, Aug 09, 2010 at 10:36:12AM +0100, Liam Girdwood wrote: > > On Mon, 2010-08-09 at 11:15 +0200, Samuel Ortiz wrote: > > > Hi Axel, > > > > > > On Mon, Aug 09, 2010 at 02:48:16PM +0800, Axel Lin wrote: > > > > The i2c_client received in probe() should not be kfree()'d. > > > This should go through Liam's tree, I'm CC'ing him to this thread. > > > > Thanks, I assume I have you Ack too ? > Yup, sorry about that: > Signed-off-by: Samuel Ortiz <sameo(a)linux.intel.com> > Applied. Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |